Title: [104430] trunk/Source/WebCore
Revision
104430
Author
[email protected]
Date
2012-01-08 22:01:14 -0800 (Sun, 08 Jan 2012)

Log Message

Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=75820

Patch by ChangSeok Oh <[email protected]> on 2012-01-08
Reviewed by Darin Adler.

Dbates submitted a patch to release fastMalloc allocation
in GraphicsContext3DOpenGL.cpp properly.
See http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
But one thing similar to the above still remains mismatched.

No new tests required.

* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::getShaderInfoLog):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (104429 => 104430)


--- trunk/Source/WebCore/ChangeLog	2012-01-09 04:27:01 UTC (rev 104429)
+++ trunk/Source/WebCore/ChangeLog	2012-01-09 06:01:14 UTC (rev 104430)
@@ -1,3 +1,20 @@
+2012-01-08  ChangSeok Oh  <[email protected]>
+
+        Memory allocation mismatch by using adoptArrayPtr in GraphicsContext3DOpenGL.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=75820
+
+        Reviewed by Darin Adler.
+
+        Dbates submitted a patch to release fastMalloc allocation
+        in GraphicsContext3DOpenGL.cpp properly.
+        See http://trac.webkit.org/browser/trunk/Source/WebCore/ChangeLog?rev=104395
+        But one thing similar to the above still remains mismatched.
+
+        No new tests required.
+
+        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+        (WebCore::GraphicsContext3D::getShaderInfoLog):
+
 2012-01-08  Leo Yang  <[email protected]>
 
         [BlackBerry] Use the concrete FrameNetworkingContextBlackBerry to access Frame

Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp (104429 => 104430)


--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp	2012-01-09 04:27:01 UTC (rev 104429)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp	2012-01-09 06:01:14 UTC (rev 104430)
@@ -1315,7 +1315,7 @@
         return String(); 
 
     GLsizei size = 0;
-    OwnArrayPtr<GLchar> info = adoptArrayPtr(static_cast<GLchar*>(fastMalloc(length)));
+    OwnArrayPtr<GLchar> info = adoptArrayPtr(new GLchar[length]);
     ::glGetShaderInfoLog(shader, length, &size, info.get());
 
     return String(info.get());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to