Title: [262877] trunk/Source/WebCore
- Revision
- 262877
- Author
- commit-qu...@webkit.org
- Date
- 2020-06-10 17:10:30 -0700 (Wed, 10 Jun 2020)
Log Message
Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=212714
Patch by Pinki Gyanchandani <pgyanchand...@apple.com> on 2020-06-10
Reviewed by Geoffrey Garen.
Replaced call to WTFMove(widgetNewParentMap()) with std::exchange(widgetNewParentMap(), { }) in the
WidgetHierarchyUpdatesSuspensionScope::moveWidgets(), thereby making it explicit to set the source map empty.
Test would be added later.
* rendering/RenderWidget.cpp:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (262876 => 262877)
--- trunk/Source/WebCore/ChangeLog 2020-06-11 00:07:51 UTC (rev 262876)
+++ trunk/Source/WebCore/ChangeLog 2020-06-11 00:10:30 UTC (rev 262877)
@@ -1,3 +1,18 @@
+2020-06-10 Pinki Gyanchandani <pgyanchand...@apple.com>
+
+ Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
+ https://bugs.webkit.org/show_bug.cgi?id=212714
+
+ Reviewed by Geoffrey Garen.
+
+ Replaced call to WTFMove(widgetNewParentMap()) with std::exchange(widgetNewParentMap(), { }) in the
+ WidgetHierarchyUpdatesSuspensionScope::moveWidgets(), thereby making it explicit to set the source map empty.
+
+ Test would be added later.
+
+ * rendering/RenderWidget.cpp:
+ (WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
+
2020-06-10 Brent Fulgham <bfulg...@apple.com>
Improve CSP compliance under PSON
Modified: trunk/Source/WebCore/rendering/RenderWidget.cpp (262876 => 262877)
--- trunk/Source/WebCore/rendering/RenderWidget.cpp 2020-06-11 00:07:51 UTC (rev 262876)
+++ trunk/Source/WebCore/rendering/RenderWidget.cpp 2020-06-11 00:10:30 UTC (rev 262877)
@@ -57,7 +57,7 @@
void WidgetHierarchyUpdatesSuspensionScope::moveWidgets()
{
while (!widgetNewParentMap().isEmpty()) {
- auto map = WTFMove(widgetNewParentMap());
+ auto map = std::exchange(widgetNewParentMap(), { });
for (auto& entry : map) {
auto& child = *entry.key;
auto* currentParent = child.parent();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
