Title: [262898] trunk/Source/WebCore
Revision
262898
Author
[email protected]
Date
2020-06-11 01:09:33 -0700 (Thu, 11 Jun 2020)

Log Message

[WebXR] Pass an unsigned long to cancelAnimationCallback() as handle
https://bugs.webkit.org/show_bug.cgi?id=212529

Reviewed by Youenn Fablet.

The type of the handle returned by XRSession::requestAnimationFrame() was recently changed
to unsigned long from long as there was no point in using signed integers for that. However
we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle
returned by requestAnimationFrame().

We landed https://github.com/immersive-web/webxr/pull/1069 in the WebXR specs so we can now
safely also replace signed by unsigned integers in our implementation.

No new tests as there is no change in functionality.

Reland r262718.

* Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids.
* Modules/webxr/WebXRSession.h: Ditto.
* Modules/webxr/WebXRSession.idl: Ditto.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (262897 => 262898)


--- trunk/Source/WebCore/ChangeLog	2020-06-11 07:52:46 UTC (rev 262897)
+++ trunk/Source/WebCore/ChangeLog	2020-06-11 08:09:33 UTC (rev 262898)
@@ -1,3 +1,27 @@
+2020-06-10  Sergio Villar Senin  <[email protected]>
+
+        [WebXR] Pass an unsigned long to cancelAnimationCallback() as handle
+        https://bugs.webkit.org/show_bug.cgi?id=212529
+
+        Reviewed by Youenn Fablet.
+
+        The type of the handle returned by XRSession::requestAnimationFrame() was recently changed
+        to unsigned long from long as there was no point in using signed integers for that. However
+        we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle
+        returned by requestAnimationFrame().
+
+        We landed https://github.com/immersive-web/webxr/pull/1069 in the WebXR specs so we can now
+        safely also replace signed by unsigned integers in our implementation.
+
+        No new tests as there is no change in functionality.
+
+        Reland r262718.
+
+        * Modules/webxr/WebXRSession.cpp:
+        (WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids.
+        * Modules/webxr/WebXRSession.h: Ditto.
+        * Modules/webxr/WebXRSession.idl: Ditto.
+
 2020-06-11  Antoine Quint  <[email protected]>
 
         [Web Animations] Setting the style at the last style change event to null should not create an ElementAnimationRareData object

Modified: trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp (262897 => 262898)


--- trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp	2020-06-11 07:52:46 UTC (rev 262897)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp	2020-06-11 08:09:33 UTC (rev 262898)
@@ -214,7 +214,7 @@
 }
 
 // https://immersive-web.github.io/webxr/#dom-xrsession-cancelanimationframe
-void WebXRSession::cancelAnimationFrame(int callbackId)
+void WebXRSession::cancelAnimationFrame(XRFrameRequestCallback::Id callbackId)
 {
     // 1. Let session be the target XRSession object.
     // 2. Find the entry in session's list of animation frame callbacks or session's list of

Modified: trunk/Source/WebCore/Modules/webxr/WebXRSession.h (262897 => 262898)


--- trunk/Source/WebCore/Modules/webxr/WebXRSession.h	2020-06-11 07:52:46 UTC (rev 262897)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSession.h	2020-06-11 08:09:33 UTC (rev 262898)
@@ -74,7 +74,7 @@
     void requestReferenceSpace(XRReferenceSpaceType, RequestReferenceSpacePromise&&);
 
     XRFrameRequestCallback::Id requestAnimationFrame(Ref<XRFrameRequestCallback>&&);
-    void cancelAnimationFrame(int handle);
+    void cancelAnimationFrame(XRFrameRequestCallback::Id handle);
 
     void end(EndPromise&&);
 

Modified: trunk/Source/WebCore/Modules/webxr/WebXRSession.idl (262897 => 262898)


--- trunk/Source/WebCore/Modules/webxr/WebXRSession.idl	2020-06-11 07:52:46 UTC (rev 262897)
+++ trunk/Source/WebCore/Modules/webxr/WebXRSession.idl	2020-06-11 08:09:33 UTC (rev 262898)
@@ -43,7 +43,7 @@
     [NewObject] Promise<WebXRReferenceSpace> requestReferenceSpace(XRReferenceSpaceType type);
 
     unsigned long requestAnimationFrame(XRFrameRequestCallback callback);
-    void cancelAnimationFrame(long handle);
+    void cancelAnimationFrame(unsigned long handle);
 
     Promise<void> end();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to