Title: [262910] trunk/LayoutTests
- Revision
- 262910
- Author
- [email protected]
- Date
- 2020-06-11 10:57:12 -0700 (Thu, 11 Jun 2020)
Log Message
[iOS] editing/selection/ios/update-selection-after-overflow-scroll.html times out
https://bugs.webkit.org/show_bug.cgi?id=213082
<rdar://problem/64228007>
Reviewed by Megan Gardner.
This test makes a programmatic selection, and then scrolls an overflow area with accelerated scrolling by using
`UIHelper.immediateScrollElementAtContentPointToOffset()`. This helper method hit-tests for a subscrollable
region, and then uses platform API to change the content offset. However, after timing changes in the system,
this hit-testing now fails because it ends up finding the callout menu that shows up after making the text
selection, and so scrolling fails.
Fix this by using (40, 40) instead of (150, 100) when hit-testing the child scroll view when scrolling.
* editing/selection/ios/update-selection-after-overflow-scroll.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (262909 => 262910)
--- trunk/LayoutTests/ChangeLog 2020-06-11 17:51:59 UTC (rev 262909)
+++ trunk/LayoutTests/ChangeLog 2020-06-11 17:57:12 UTC (rev 262910)
@@ -1,3 +1,21 @@
+2020-06-11 Wenson Hsieh <[email protected]>
+
+ [iOS] editing/selection/ios/update-selection-after-overflow-scroll.html times out
+ https://bugs.webkit.org/show_bug.cgi?id=213082
+ <rdar://problem/64228007>
+
+ Reviewed by Megan Gardner.
+
+ This test makes a programmatic selection, and then scrolls an overflow area with accelerated scrolling by using
+ `UIHelper.immediateScrollElementAtContentPointToOffset()`. This helper method hit-tests for a subscrollable
+ region, and then uses platform API to change the content offset. However, after timing changes in the system,
+ this hit-testing now fails because it ends up finding the callout menu that shows up after making the text
+ selection, and so scrolling fails.
+
+ Fix this by using (40, 40) instead of (150, 100) when hit-testing the child scroll view when scrolling.
+
+ * editing/selection/ios/update-selection-after-overflow-scroll.html:
+
2020-06-11 Pinki Gyanchandani <[email protected]>
Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
Modified: trunk/LayoutTests/editing/selection/ios/update-selection-after-overflow-scroll.html (262909 => 262910)
--- trunk/LayoutTests/editing/selection/ios/update-selection-after-overflow-scroll.html 2020-06-11 17:51:59 UTC (rev 262909)
+++ trunk/LayoutTests/editing/selection/ios/update-selection-after-overflow-scroll.html 2020-06-11 17:57:12 UTC (rev 262910)
@@ -63,7 +63,8 @@
await UIHelper.activateElementAndWaitForInputSession(button);
selectionRectsBefore = await waitForSelectionRectsToChange([]);
- await UIHelper.immediateScrollElementAtContentPointToOffset(150, 100, 0, 50);
+ const rect = editor.getBoundingClientRect();
+ await UIHelper.immediateScrollElementAtContentPointToOffset(rect.left + 40, rect.top + 40, 0, 50);
selectionRectsAfter = await waitForSelectionRectsToChange(selectionRectsBefore);
shouldBe("selectionRectsBefore[0].top", "109");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes