Title: [262925] trunk/Source/WebCore
Revision
262925
Author
[email protected]
Date
2020-06-11 14:05:39 -0700 (Thu, 11 Jun 2020)

Log Message

REGRESSION (r262776): Flaky crash under -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
https://bugs.webkit.org/show_bug.cgi?id=213059

Patch by Rob Buis <[email protected]> on 2020-06-11
Reviewed by Alex Christensen.

My r262776 patch did not null check m_handle and it can cause crashes
in some cases, so add the check.

* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (262924 => 262925)


--- trunk/Source/WebCore/ChangeLog	2020-06-11 21:02:52 UTC (rev 262924)
+++ trunk/Source/WebCore/ChangeLog	2020-06-11 21:05:39 UTC (rev 262925)
@@ -1,3 +1,16 @@
+2020-06-11  Rob Buis  <[email protected]>
+
+        REGRESSION (r262776): Flaky crash under -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
+        https://bugs.webkit.org/show_bug.cgi?id=213059
+
+        Reviewed by Alex Christensen.
+
+        My r262776 patch did not null check m_handle and it can cause crashes
+        in some cases, so add the check.
+
+        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
+
 2020-06-11  Beth Dakin  <[email protected]>
 
         Replace instances of whitelist in WebCore with allowlist

Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (262924 => 262925)


--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm	2020-06-11 21:02:52 UTC (rev 262924)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm	2020-06-11 21:05:39 UTC (rev 262925)
@@ -123,7 +123,7 @@
     // See <rdar://problem/5380697>. This is a workaround for a behavior change in CFNetwork where willSendRequest gets called more often.
     if (!redirectResponse) {
         // CFNetwork will add "application/x-www-form-urlencoded" content-type for POST, even if no Content-Type was specified, remove it in that case.
-        if (equalLettersIgnoringASCIICase(m_handle->firstRequest().httpMethod(), "post") && !m_handle->firstRequest().hasHTTPHeaderField(HTTPHeaderName::ContentType)) {
+        if (m_handle && equalLettersIgnoringASCIICase(m_handle->firstRequest().httpMethod(), "post") && !m_handle->firstRequest().hasHTTPHeaderField(HTTPHeaderName::ContentType)) {
             NSMutableURLRequest *modifiedRequest = [newRequest mutableCopy];
             [modifiedRequest setValue:nil forHTTPHeaderField:@"Content-Type"];
             return modifiedRequest;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to