Title: [262944] trunk/Tools
Revision
262944
Author
carlo...@webkit.org
Date
2020-06-12 06:21:47 -0700 (Fri, 12 Jun 2020)

Log Message

Unreviewed. Fix GTK WebDriver tests after r262938

Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowCreateBackForwardMenu):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (262943 => 262944)


--- trunk/Tools/ChangeLog	2020-06-12 09:54:53 UTC (rev 262943)
+++ trunk/Tools/ChangeLog	2020-06-12 13:21:47 UTC (rev 262944)
@@ -1,3 +1,12 @@
+2020-06-12  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        Unreviewed. Fix GTK WebDriver tests after r262938
+
+        Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (browserWindowCreateBackForwardMenu):
+
 2020-06-12  Philippe Normand  <pnorm...@igalia.com>
 
         [Flatpak SDK] Update GTK4 to 3.98.5

Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (262943 => 262944)


--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2020-06-12 09:54:53 UTC (rev 262943)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2020-06-12 13:21:47 UTC (rev 262944)
@@ -222,6 +222,8 @@
     for (listItem = list; listItem; listItem = g_list_next(listItem)) {
         WebKitBackForwardListItem *item = (WebKitBackForwardListItem *)listItem->data;
         const char *title = webkit_back_forward_list_item_get_title(item);
+        if (!title || !*title)
+            title = webkit_back_forward_list_item_get_uri(item);
 
         char *actionName = g_strdup_printf("action-%lu", ++actionId);
         GSimpleAction *action = "" NULL);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to