Title: [262963] trunk/LayoutTests
- Revision
- 262963
- Author
- ysuz...@apple.com
- Date
- 2020-06-12 11:53:37 -0700 (Fri, 12 Jun 2020)
Log Message
[ Mojave wk2 Release ] js/dom/unhandled-promise-rejection-console-no-report.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=212851
Reviewed by Darin Adler.
This test is wrong since both onunhandledrejection and setTimeout are driven by macro-tasks.
There is no ordering between them so they have race condition, and this race condition makes this
the test flaky. We should fix the test. This patch removes the dependency to setTimeout.
* js/dom/unhandled-promise-rejection-console-no-report-expected.txt:
* js/dom/unhandled-promise-rejection-console-no-report.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (262962 => 262963)
--- trunk/LayoutTests/ChangeLog 2020-06-12 18:40:25 UTC (rev 262962)
+++ trunk/LayoutTests/ChangeLog 2020-06-12 18:53:37 UTC (rev 262963)
@@ -1,3 +1,17 @@
+2020-06-12 Yusuke Suzuki <ysuz...@apple.com>
+
+ [ Mojave wk2 Release ] js/dom/unhandled-promise-rejection-console-no-report.html is flaky failing.
+ https://bugs.webkit.org/show_bug.cgi?id=212851
+
+ Reviewed by Darin Adler.
+
+ This test is wrong since both onunhandledrejection and setTimeout are driven by macro-tasks.
+ There is no ordering between them so they have race condition, and this race condition makes this
+ the test flaky. We should fix the test. This patch removes the dependency to setTimeout.
+
+ * js/dom/unhandled-promise-rejection-console-no-report-expected.txt:
+ * js/dom/unhandled-promise-rejection-console-no-report.html:
+
2020-06-12 Antoine Quint <grao...@webkit.org>
Double tap to zoom out doesn't work after upgrading to iOS 13
Modified: trunk/LayoutTests/js/dom/unhandled-promise-rejection-console-no-report-expected.txt (262962 => 262963)
--- trunk/LayoutTests/js/dom/unhandled-promise-rejection-console-no-report-expected.txt 2020-06-12 18:40:25 UTC (rev 262962)
+++ trunk/LayoutTests/js/dom/unhandled-promise-rejection-console-no-report-expected.txt 2020-06-12 18:53:37 UTC (rev 262963)
@@ -2,7 +2,6 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS count is 3
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/js/dom/unhandled-promise-rejection-console-no-report.html (262962 => 262963)
--- trunk/LayoutTests/js/dom/unhandled-promise-rejection-console-no-report.html 2020-06-12 18:40:25 UTC (rev 262962)
+++ trunk/LayoutTests/js/dom/unhandled-promise-rejection-console-no-report.html 2020-06-12 18:53:37 UTC (rev 262963)
@@ -18,14 +18,11 @@
window.count = 0;
window._onunhandledrejection_ = function (e) {
count++;
+ if (count === 3)
+ finishJSTest();
return false;
};
-setTimeout(function () {
- shouldBe(`count`, `3`);
- finishJSTest();
-}, 100);
-
</script>
<script src=""
</body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
