Title: [263003] trunk
Revision
263003
Author
[email protected]
Date
2020-06-13 11:35:39 -0700 (Sat, 13 Jun 2020)

Log Message

[WPT] dom/nodes/Document-createCDATASection-xhtml.xhtml fails due to missing exception in Document.createCDATASection()
https://bugs.webkit.org/show_bug.cgi?id=213167

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

* web-platform-tests/dom/nodes/Document-createCDATASection-xhtml-expected.txt:
Update results to show we are now passing all subtests.

Source/WebCore:

Tested by existing (formerly failing) test: imported/w3c/web-platform-tests/dom/nodes/Document-createCDATASection-xhtml.xhtml

Throw an "InvalidCharacterError" DOMException if the data passed to createCDATASection
contains the string "]]>" as specified by https://dom.spec.whatwg.org/#dom-document-createcdatasection

* dom/Document.cpp:
(WebCore::Document::createCDATASection):

LayoutTests:

* dom/xhtml/level3/core/documentnormalizedocument07-expected.txt:
* dom/xhtml/level3/core/documentnormalizedocument08-expected.txt:
* dom/xhtml/level3/core/handleerror01-expected.txt:
* dom/xhtml/level3/core/splitcdatasections01-expected.txt:
Update expected results with new error now being thrown.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (263002 => 263003)


--- trunk/LayoutTests/ChangeLog	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/ChangeLog	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,16 @@
+2020-06-13  Sam Weinig  <[email protected]>
+
+        [WPT] dom/nodes/Document-createCDATASection-xhtml.xhtml fails due to missing exception in Document.createCDATASection()
+        https://bugs.webkit.org/show_bug.cgi?id=213167
+
+        Reviewed by Yusuke Suzuki.
+
+        * dom/xhtml/level3/core/documentnormalizedocument07-expected.txt:
+        * dom/xhtml/level3/core/documentnormalizedocument08-expected.txt:
+        * dom/xhtml/level3/core/handleerror01-expected.txt:
+        * dom/xhtml/level3/core/splitcdatasections01-expected.txt:
+        Update expected results with new error now being thrown.
+
 2020-06-12  Simon Fraser  <[email protected]>
 
         REGRESSION(r261985): Unable to respond to large comments on Bugzilla with always-on scrollbars

Modified: trunk/LayoutTests/dom/xhtml/level3/core/documentnormalizedocument07-expected.txt (263002 => 263003)


--- trunk/LayoutTests/dom/xhtml/level3/core/documentnormalizedocument07-expected.txt	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/dom/xhtml/level3/core/documentnormalizedocument07-expected.txt	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/documentnormalizedocument07
 Status	error
-Message	Line 143: TypeError
+Message	Line 139: InvalidCharacterError

Modified: trunk/LayoutTests/dom/xhtml/level3/core/documentnormalizedocument08-expected.txt (263002 => 263003)


--- trunk/LayoutTests/dom/xhtml/level3/core/documentnormalizedocument08-expected.txt	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/dom/xhtml/level3/core/documentnormalizedocument08-expected.txt	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/documentnormalizedocument08
 Status	error
-Message	Line 124: TypeError
+Message	Line 116: InvalidCharacterError

Modified: trunk/LayoutTests/dom/xhtml/level3/core/handleerror01-expected.txt (263002 => 263003)


--- trunk/LayoutTests/dom/xhtml/level3/core/handleerror01-expected.txt	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/dom/xhtml/level3/core/handleerror01-expected.txt	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/handleerror01
 Status	error
-Message	Line 150: TypeError
+Message	Line 144: InvalidCharacterError

Modified: trunk/LayoutTests/dom/xhtml/level3/core/splitcdatasections01-expected.txt (263002 => 263003)


--- trunk/LayoutTests/dom/xhtml/level3/core/splitcdatasections01-expected.txt	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/dom/xhtml/level3/core/splitcdatasections01-expected.txt	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/splitcdatasections01
 Status	error
-Message	Line 115: TypeError
+Message	Line 111: InvalidCharacterError

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (263002 => 263003)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,13 @@
+2020-06-13  Sam Weinig  <[email protected]>
+
+        [WPT] dom/nodes/Document-createCDATASection-xhtml.xhtml fails due to missing exception in Document.createCDATASection()
+        https://bugs.webkit.org/show_bug.cgi?id=213167
+
+        Reviewed by Yusuke Suzuki.
+
+        * web-platform-tests/dom/nodes/Document-createCDATASection-xhtml-expected.txt:
+        Update results to show we are now passing all subtests.
+
 2020-06-12  Tetsuharu Ohzeki  <[email protected]>
 
         Change FileReader.error to DOMException from obsoleted FileError

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createCDATASection-xhtml-expected.txt (263002 => 263003)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createCDATASection-xhtml-expected.txt	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createCDATASection-xhtml-expected.txt	2020-06-13 18:35:39 UTC (rev 263003)
@@ -5,5 +5,5 @@
 PASS createCDATASection("-b") 
 PASS createCDATASection(null) 
 PASS createCDATASection(undefined) 
-FAIL Creating a CDATA section containing the string "]]>" must throw assert_throws_dom: function "() => document.createCDATASection(" ]" + "]>  ")" did not throw
+PASS Creating a CDATA section containing the string "]]>" must throw 
 

Modified: trunk/Source/WebCore/ChangeLog (263002 => 263003)


--- trunk/Source/WebCore/ChangeLog	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/Source/WebCore/ChangeLog	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1,3 +1,18 @@
+2020-06-13  Sam Weinig  <[email protected]>
+
+        [WPT] dom/nodes/Document-createCDATASection-xhtml.xhtml fails due to missing exception in Document.createCDATASection()
+        https://bugs.webkit.org/show_bug.cgi?id=213167
+
+        Reviewed by Yusuke Suzuki.
+
+        Tested by existing (formerly failing) test: imported/w3c/web-platform-tests/dom/nodes/Document-createCDATASection-xhtml.xhtml
+
+        Throw an "InvalidCharacterError" DOMException if the data passed to createCDATASection
+        contains the string "]]>" as specified by https://dom.spec.whatwg.org/#dom-document-createcdatasection
+
+        * dom/Document.cpp:
+        (WebCore::Document::createCDATASection):
+
 2020-06-13  Michael Catanzaro  <[email protected]>
 
         Obsolete comment in FontCustomPlatformDataFreeType.cpp

Modified: trunk/Source/WebCore/dom/Document.cpp (263002 => 263003)


--- trunk/Source/WebCore/dom/Document.cpp	2020-06-13 18:24:49 UTC (rev 263002)
+++ trunk/Source/WebCore/dom/Document.cpp	2020-06-13 18:35:39 UTC (rev 263003)
@@ -1027,6 +1027,10 @@
 {
     if (isHTMLDocument())
         return Exception { NotSupportedError };
+
+    if (data.contains("]]>"))
+        return Exception { InvalidCharacterError };
+
     return CDATASection::create(*this, data);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to