Title: [263010] trunk/Source/WebKit
Revision
263010
Author
[email protected]
Date
2020-06-14 02:07:16 -0700 (Sun, 14 Jun 2020)

Log Message

[SOUP] Disable HSTS for requests when cookies will be blocked by ITP
https://bugs.webkit.org/show_bug.cgi?id=210739

Reviewed by Michael Catanzaro.

* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::shouldAllowHSTSProtocolUpgrade const):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (263009 => 263010)


--- trunk/Source/WebKit/ChangeLog	2020-06-14 07:11:10 UTC (rev 263009)
+++ trunk/Source/WebKit/ChangeLog	2020-06-14 09:07:16 UTC (rev 263010)
@@ -1,3 +1,13 @@
+2020-06-14  Carlos Garcia Campos  <[email protected]>
+
+        [SOUP] Disable HSTS for requests when cookies will be blocked by ITP
+        https://bugs.webkit.org/show_bug.cgi?id=210739
+
+        Reviewed by Michael Catanzaro.
+
+        * NetworkProcess/soup/NetworkDataTaskSoup.cpp:
+        (WebKit::NetworkDataTaskSoup::shouldAllowHSTSProtocolUpgrade const):
+
 2020-06-13  Richard Houle  <[email protected]>
 
         Fix Overrelease in makeFailureSetForAllTextManipulationItems

Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp (263009 => 263010)


--- trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp	2020-06-14 07:11:10 UTC (rev 263009)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp	2020-06-14 09:07:16 UTC (rev 263010)
@@ -1133,7 +1133,7 @@
     // Follow Apple's HSTS abuse mitigation 2:
     // "Ignore HSTS State for Subresource Requests to Blocked Domains"
     return isTopLevelNavigation()
-        || m_currentRequest.allowCookies();
+        && !m_isBlockingCookies;
 }
 
 void NetworkDataTaskSoup::protocolUpgradedViaHSTS(SoupMessage* soupMessage)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to