Title: [263019] trunk/Source/WebCore
Revision
263019
Author
[email protected]
Date
2020-06-15 00:42:30 -0700 (Mon, 15 Jun 2020)

Log Message

MediaRecorder should not be collectable when fetching data from its backend
https://bugs.webkit.org/show_bug.cgi?id=213121

Reviewed by Eric Carlson.

Take a pending activity when fetching data since we might want dispatch an event when receiving the fetch data.
Covered by existing tests no longer crashing in debug.

* Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (263018 => 263019)


--- trunk/Source/WebCore/ChangeLog	2020-06-15 05:56:50 UTC (rev 263018)
+++ trunk/Source/WebCore/ChangeLog	2020-06-15 07:42:30 UTC (rev 263019)
@@ -1,3 +1,17 @@
+2020-06-15  Youenn Fablet  <[email protected]>
+
+        MediaRecorder should not be collectable when fetching data from its backend
+        https://bugs.webkit.org/show_bug.cgi?id=213121
+
+        Reviewed by Eric Carlson.
+
+        Take a pending activity when fetching data since we might want dispatch an event when receiving the fetch data.
+        Covered by existing tests no longer crashing in debug.
+
+        * Modules/mediarecorder/MediaRecorder.cpp:
+        (WebCore::MediaRecorder::stopRecording):
+        (WebCore::MediaRecorder::requestData):
+
 2020-06-14  Sergio Villar Senin  <[email protected]>
 
         Unreviewed, reverting r262124.

Modified: trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp (263018 => 263019)


--- trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp	2020-06-15 05:56:50 UTC (rev 263018)
+++ trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp	2020-06-15 07:42:30 UTC (rev 263019)
@@ -153,7 +153,7 @@
 
         stopRecordingInternal();
         ASSERT(m_state == RecordingState::Inactive);
-        m_private->fetchData([this, protectedThis = makeRef(*this)](auto&& buffer, auto& mimeType) {
+        m_private->fetchData([this, pendingActivity = makePendingActivity(*this)](auto&& buffer, auto& mimeType) {
             if (!m_isActive)
                 return;
     
@@ -173,7 +173,7 @@
     if (state() == RecordingState::Inactive)
         return Exception { InvalidStateError, "The MediaRecorder's state cannot be inactive"_s };
 
-    m_private->fetchData([this, protectedThis = makeRef(*this)](auto&& buffer, auto& mimeType) {
+    m_private->fetchData([this, pendingActivity = makePendingActivity(*this)](auto&& buffer, auto& mimeType) {
         if (!m_isActive)
             return;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to