Title: [263039] trunk/Source/WTF
- Revision
- 263039
- Author
- [email protected]
- Date
- 2020-06-15 08:57:39 -0700 (Mon, 15 Jun 2020)
Log Message
Pack bytes a little tighter in MemoryPressureHandler
https://bugs.webkit.org/show_bug.cgi?id=200392
Reviewed by Yusuke Suzuki.
Save a tiny bit of memory by packing member variables tighter in MemoryPressureHandler.
* wtf/MemoryPressureHandler.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (263038 => 263039)
--- trunk/Source/WTF/ChangeLog 2020-06-15 15:44:40 UTC (rev 263038)
+++ trunk/Source/WTF/ChangeLog 2020-06-15 15:57:39 UTC (rev 263039)
@@ -1,3 +1,14 @@
+2020-06-15 Per Arne Vollan <[email protected]>
+
+ Pack bytes a little tighter in MemoryPressureHandler
+ https://bugs.webkit.org/show_bug.cgi?id=200392
+
+ Reviewed by Yusuke Suzuki.
+
+ Save a tiny bit of memory by packing member variables tighter in MemoryPressureHandler.
+
+ * wtf/MemoryPressureHandler.h:
+
2020-06-12 Keith Miller <[email protected]>
Tests expecting a crash should use a signal handler in the JSC CLI process
Modified: trunk/Source/WTF/wtf/MemoryPressureHandler.h (263038 => 263039)
--- trunk/Source/WTF/wtf/MemoryPressureHandler.h 2020-06-15 15:44:40 UTC (rev 263038)
+++ trunk/Source/WTF/wtf/MemoryPressureHandler.h 2020-06-15 15:57:39 UTC (rev 263039)
@@ -40,13 +40,13 @@
namespace WTF {
-enum class MemoryUsagePolicy {
+enum class MemoryUsagePolicy : uint8_t {
Unrestricted, // Allocate as much as you want
Conservative, // Maybe you don't cache every single thing
Strict, // Time to start pinching pennies for real
};
-enum class WebsamProcessState {
+enum class WebsamProcessState : uint8_t {
Active,
Inactive,
};
@@ -176,12 +176,8 @@
void doesExceedInactiveLimitWhileActive();
void doesNotExceedInactiveLimitWhileActive();
- WebsamProcessState m_processState { WebsamProcessState::Inactive };
-
unsigned m_pageCount { 0 };
- LowMemoryHandler m_lowMemoryHandler;
-
std::atomic<bool> m_underMemoryPressure { false };
bool m_installed { false };
bool m_isSimulatingMemoryPressure { false };
@@ -188,11 +184,15 @@
bool m_shouldLogMemoryMemoryPressureEvents { true };
bool m_hasInvokedDidExceedInactiveLimitWhileActiveCallback { false };
+ WebsamProcessState m_processState { WebsamProcessState::Inactive };
+
+ MemoryUsagePolicy m_memoryUsagePolicy { MemoryUsagePolicy::Unrestricted };
+
std::unique_ptr<RunLoop::Timer<MemoryPressureHandler>> m_measurementTimer;
- MemoryUsagePolicy m_memoryUsagePolicy { MemoryUsagePolicy::Unrestricted };
WTF::Function<void()> m_memoryKillCallback;
WTF::Function<void(bool)> m_memoryPressureStatusChangedCallback;
WTF::Function<void()> m_didExceedInactiveLimitWhileActiveCallback;
+ LowMemoryHandler m_lowMemoryHandler;
#if OS(WINDOWS)
void windowsMeasurementTimerFired();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes