Title: [263041] trunk/Source
Revision
263041
Author
[email protected]
Date
2020-06-15 09:44:01 -0700 (Mon, 15 Jun 2020)

Log Message

Suppress compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=213034

Patch by Víctor Manuel Jáquez Leal <[email protected]> on 2020-06-15
Reviewed by Darin Adler.

Source/WebCore:

Use PRIu64 formatter for uint64_t instead of %llu.

No functional changes.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):

Source/WebKit:

Convert to std:size_t to compare equal data types.

* NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::readOrMakeSalt):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (263040 => 263041)


--- trunk/Source/WebCore/ChangeLog	2020-06-15 16:42:29 UTC (rev 263040)
+++ trunk/Source/WebCore/ChangeLog	2020-06-15 16:44:01 UTC (rev 263041)
@@ -1,3 +1,17 @@
+2020-06-15  Víctor Manuel Jáquez Leal  <[email protected]>
+
+        Suppress compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=213034
+
+        Reviewed by Darin Adler.
+
+        Use PRIu64 formatter for uint64_t instead of %llu.
+
+        No functional changes.
+
+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+        (WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
+
 2020-06-15  ChangSeok Oh  <[email protected]>
 
         [GTK] Use GRefPtr for ManetteMonitor

Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (263040 => 263041)


--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2020-06-15 16:42:29 UTC (rev 263040)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2020-06-15 16:44:01 UTC (rev 263041)
@@ -778,7 +778,7 @@
     auto indexSize = estimateSize(*objectStoreInfo, indexKeys, keySize);
     auto taskSize = defaultWriteOperationCost + keySize + valueSize + indexSize;
 
-    LOG(IndexedDB, "UniqueIDBDatabase::putOrAdd quota check with task size: %llu key size: %llu value size: %llu index size: %llu", taskSize, keySize, valueSize, indexSize);
+    LOG(IndexedDB, "UniqueIDBDatabase::putOrAdd quota check with task size: %" PRIu64 " key size: %" PRIu64 " value size: %" PRIu64 " index size: %" PRIu64, taskSize, keySize, valueSize, indexSize);
 
     if (m_server.requestSpace(m_identifier.origin(), taskSize) == StorageQuotaManager::Decision::Deny) {
         callback(IDBError { QuotaExceededError, quotaErrorMessageName("PutOrAdd") }, usedKey);

Modified: trunk/Source/WebKit/ChangeLog (263040 => 263041)


--- trunk/Source/WebKit/ChangeLog	2020-06-15 16:42:29 UTC (rev 263040)
+++ trunk/Source/WebKit/ChangeLog	2020-06-15 16:44:01 UTC (rev 263041)
@@ -1,3 +1,15 @@
+2020-06-15  Víctor Manuel Jáquez Leal  <[email protected]>
+
+        Suppress compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=213034
+
+        Reviewed by Darin Adler.
+
+        Convert to std:size_t to compare equal data types.
+
+        * NetworkProcess/cache/NetworkCacheData.cpp:
+        (WebKit::NetworkCache::readOrMakeSalt):
+
 2020-06-15  Chris Dumez  <[email protected]>
 
         Revert r260856 as it seems to have regressed PLT on iOS

Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp (263040 => 263041)


--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp	2020-06-15 16:42:29 UTC (rev 263040)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp	2020-06-15 16:44:01 UTC (rev 263041)
@@ -149,7 +149,7 @@
     if (FileSystem::fileExists(path)) {
         auto file = FileSystem::openFile(path, FileSystem::FileOpenMode::Read);
         Salt salt;
-        auto bytesRead = FileSystem::readFromFile(file, reinterpret_cast<char*>(salt.data()), salt.size());
+        auto bytesRead = static_cast<std::size_t>(FileSystem::readFromFile(file, reinterpret_cast<char*>(salt.data()), salt.size()));
         FileSystem::closeFile(file);
         if (bytesRead == salt.size())
             return salt;
@@ -159,7 +159,7 @@
 
     Salt salt = makeSalt();
     auto file = FileSystem::openFile(path, FileSystem::FileOpenMode::Write, FileSystem::FileAccessPermission::User);
-    bool success = FileSystem::writeToFile(file, reinterpret_cast<char*>(salt.data()), salt.size()) == salt.size();
+    bool success = static_cast<std::size_t>(FileSystem::writeToFile(file, reinterpret_cast<char*>(salt.data()), salt.size())) == salt.size();
     FileSystem::closeFile(file);
     if (!success)
         return { };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to