Title: [263065] trunk/Source/WTF
Revision
263065
Author
[email protected]
Date
2020-06-15 15:24:31 -0700 (Mon, 15 Jun 2020)

Log Message

REGRESSION (r263045): TestWTF.Signals.SignalsWorkOnExit crashing
https://bugs.webkit.org/show_bug.cgi?id=213211

Reviewed by Mark Lam.

Don't call toMachMask on Signal::Usr as mach doesn't support user exceptions.

* wtf/threads/Signals.cpp:
(WTF::SignalHandlers::add):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (263064 => 263065)


--- trunk/Source/WTF/ChangeLog	2020-06-15 22:09:40 UTC (rev 263064)
+++ trunk/Source/WTF/ChangeLog	2020-06-15 22:24:31 UTC (rev 263065)
@@ -1,3 +1,15 @@
+2020-06-15  Keith Miller  <[email protected]>
+
+        REGRESSION (r263045): TestWTF.Signals.SignalsWorkOnExit crashing
+        https://bugs.webkit.org/show_bug.cgi?id=213211
+
+        Reviewed by Mark Lam.
+
+        Don't call toMachMask on Signal::Usr as mach doesn't support user exceptions.
+
+        * wtf/threads/Signals.cpp:
+        (WTF::SignalHandlers::add):
+
 2020-06-15  Michael Catanzaro  <[email protected]>
 
         Consistently use WTF_ATTRIBUTE_PRINTF in Assertions.[cpp,h]

Modified: trunk/Source/WTF/wtf/threads/Signals.cpp (263064 => 263065)


--- trunk/Source/WTF/wtf/threads/Signals.cpp	2020-06-15 22:09:40 UTC (rev 263064)
+++ trunk/Source/WTF/wtf/threads/Signals.cpp	2020-06-15 22:24:31 UTC (rev 263065)
@@ -66,7 +66,8 @@
     size_t signalIndex = static_cast<size_t>(signal);
     size_t nextFree = numberOfHandlers[signalIndex];
 #if HAVE(MACH_EXCEPTIONS)
-    addedExceptions |= toMachMask(signal);
+    if (signal != Signal::Usr)
+        addedExceptions |= toMachMask(signal);
 #endif
     RELEASE_ASSERT(nextFree < maxNumberOfHandlers);
     SignalHandlerMemory* memory = &handlers[signalIndex][nextFree];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to