Title: [263068] trunk/Source/_javascript_Core
- Revision
- 263068
- Author
- [email protected]
- Date
- 2020-06-15 17:10:31 -0700 (Mon, 15 Jun 2020)
Log Message
testB3::testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead() has a validation failure in debug mode
https://bugs.webkit.org/show_bug.cgi?id=196103
<rdar://problem/57808549>
Reviewed by Keith Miller.
The problem was trivial: patchpoints were referring to constants that were defined after them.
Just exchanging the order of the definition was enough to make this test pass.
* b3/testb3_1.cpp:
(shouldRun):
* b3/testb3_7.cpp:
(testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (263067 => 263068)
--- trunk/Source/_javascript_Core/ChangeLog 2020-06-15 23:00:04 UTC (rev 263067)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-06-16 00:10:31 UTC (rev 263068)
@@ -1,3 +1,19 @@
+2020-06-15 Robin Morisset <[email protected]>
+
+ testB3::testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead() has a validation failure in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=196103
+ <rdar://problem/57808549>
+
+ Reviewed by Keith Miller.
+
+ The problem was trivial: patchpoints were referring to constants that were defined after them.
+ Just exchanging the order of the definition was enough to make this test pass.
+
+ * b3/testb3_1.cpp:
+ (shouldRun):
+ * b3/testb3_7.cpp:
+ (testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead):
+
2020-06-15 Mark Lam <[email protected]>
Do not install the VMTraps signal handler if Options::useJIT=false.
Modified: trunk/Source/_javascript_Core/b3/testb3_1.cpp (263067 => 263068)
--- trunk/Source/_javascript_Core/b3/testb3_1.cpp 2020-06-15 23:00:04 UTC (rev 263067)
+++ trunk/Source/_javascript_Core/b3/testb3_1.cpp 2020-06-16 00:10:31 UTC (rev 263068)
@@ -35,7 +35,6 @@
// FIXME: These tests fail <https://bugs.webkit.org/show_bug.cgi?id=199330>.
if (!filter && isARM64()) {
for (auto& failingTest : {
- "testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead",
"testNegFloatWithUselessDoubleConversion",
"testPinRegisters",
}) {
@@ -45,16 +44,6 @@
}
}
}
- if (!filter && isX86()) {
- for (auto& failingTest : {
- "testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead",
- }) {
- if (WTF::findIgnoringASCIICaseWithoutLength(testName, failingTest) != WTF::notFound) {
- dataLogLn("*** Warning: Skipping known-bad test: ", testName);
- return false;
- }
- }
- }
return !filter || WTF::findIgnoringASCIICaseWithoutLength(testName, filter) != WTF::notFound;
}
Modified: trunk/Source/_javascript_Core/b3/testb3_7.cpp (263067 => 263068)
--- trunk/Source/_javascript_Core/b3/testb3_7.cpp 2020-06-15 23:00:04 UTC (rev 263067)
+++ trunk/Source/_javascript_Core/b3/testb3_7.cpp 2020-06-16 00:10:31 UTC (rev 263068)
@@ -1468,8 +1468,8 @@
{
// Make every reg 42 (just needs to be a value other than 10).
+ Value* const42 = root->appendNew<Const32Value>(proc, Origin(), 42);
PatchpointValue* patchpoint = root->appendNew<PatchpointValue>(proc, Void, Origin());
- Value* const42 = root->appendNew<Const32Value>(proc, Origin(), 42);
for (Reg reg : allRegs)
patchpoint->append(const42, ValueRep::reg(reg));
patchpoint->setGenerator([&] (CCallHelpers&, const StackmapGenerationParams&) { });
@@ -1476,8 +1476,8 @@
}
{
+ Value* const10 = root->appendNew<Const32Value>(proc, Origin(), 10);
PatchpointValue* patchpoint = root->appendNew<PatchpointValue>(proc, Void, Origin());
- Value* const10 = root->appendNew<Const32Value>(proc, Origin(), 10);
for (Reg reg : allRegs)
patchpoint->append(const10, ValueRep::lateReg(reg));
patchpoint->setGenerator([&] (CCallHelpers& jit, const StackmapGenerationParams&) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes