Title: [263081] trunk/LayoutTests
- Revision
- 263081
- Author
- [email protected]
- Date
- 2020-06-16 00:29:44 -0700 (Tue, 16 Jun 2020)
Log Message
REGRESSION: [ Mac ] inspector/page/setBootstrapScript-sub-frame.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=213087
<rdar://problem/64262900>
Reviewed by Maciej Stachowiak.
* inspector/page/setBootstrapScript-sub-frame.html:
* inspector/page/resources/bootstrap-iframe.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (263080 => 263081)
--- trunk/LayoutTests/ChangeLog 2020-06-16 07:28:45 UTC (rev 263080)
+++ trunk/LayoutTests/ChangeLog 2020-06-16 07:29:44 UTC (rev 263081)
@@ -1,3 +1,16 @@
+2020-06-16 Devin Rousso <[email protected]>
+
+ REGRESSION: [ Mac ] inspector/page/setBootstrapScript-sub-frame.html is flaky failing.
+ https://bugs.webkit.org/show_bug.cgi?id=213087
+ <rdar://problem/64262900>
+
+ Reviewed by Maciej Stachowiak.
+
+ * inspector/page/setBootstrapScript-sub-frame.html:
+ * inspector/page/resources/bootstrap-iframe.html:
+
+ * platform/mac/TestExpectations:
+
2020-06-16 Youenn Fablet <[email protected]>
LayoutTest imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a flaky failure
Modified: trunk/LayoutTests/inspector/page/resources/bootstrap-iframe.html (263080 => 263081)
--- trunk/LayoutTests/inspector/page/resources/bootstrap-iframe.html 2020-06-16 07:28:45 UTC (rev 263080)
+++ trunk/LayoutTests/inspector/page/resources/bootstrap-iframe.html 2020-06-16 07:29:44 UTC (rev 263081)
@@ -1,8 +1,10 @@
<html>
+<head>
+ <script src=""
+</head>
<body>
-<script>
-if (!window.valueFromBootstrapScript)
- TestPage.addResult("FAIL: Should have set 'window.valueFromBootstrapScript'.");
-</script>
+ <script>
+TestPage.dispatchEventToFrontend("TestPage-subframe-valueFromBootstrapScript", window.valueFromBootstrapScript);
+ </script>
</body>
-</html>
\ No newline at end of file
+</html>
Modified: trunk/LayoutTests/inspector/page/setBootstrapScript-sub-frame.html (263080 => 263081)
--- trunk/LayoutTests/inspector/page/setBootstrapScript-sub-frame.html 2020-06-16 07:28:45 UTC (rev 263080)
+++ trunk/LayoutTests/inspector/page/setBootstrapScript-sub-frame.html 2020-06-16 07:29:44 UTC (rev 263081)
@@ -22,22 +22,13 @@
WI.networkManager.bootstrapScript.currentRevision.updateRevisionContent(`window.valueFromBootstrapScript = 42;`);
InspectorTest.log("Adding subframe...");
- let [frameWasAddedEvent] = await Promise.all([
+ let [valueFromBootstrapScriptEvent] = await Promise.all([
+ InspectorTest.awaitEvent("TestPage-subframe-valueFromBootstrapScript"),
WI.networkManager.awaitEvent(WI.NetworkManager.Event.FrameWasAdded),
InspectorTest.evaluateInPage(`addSubframe()`),
]);
- let {frame} = frameWasAddedEvent.data;
-
- if (!frame.pageExecutionContext)
- await frame.awaitEvent(WI.Frame.Event.PageExecutionContextChanged);
-
- let {result} = await RuntimeAgent.evaluate.invoke({
- _expression_: `window.valueFromBootstrapScript`,
- contextId: frame.pageExecutionContext.id,
- returnByValue: true,
- });
- InspectorTest.expectEqual(result.value, 42, "'valueFromBootstrapScript' should be '42'.");
+ InspectorTest.expectEqual(valueFromBootstrapScriptEvent.data, 42, "'valueFromBootstrapScript' should be '42'.");
},
});
Modified: trunk/LayoutTests/platform/mac/TestExpectations (263080 => 263081)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-06-16 07:28:45 UTC (rev 263080)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-06-16 07:29:44 UTC (rev 263081)
@@ -1942,5 +1942,3 @@
# This test requires an update to system decoders
webkit.org/b/212565 [ Catalina Mojave ] imported/w3c/web-platform-tests/encoding/single-byte-decoder.html [ Failure ]
-
-webkit.org/b/213087 inspector/page/setBootstrapScript-sub-frame.html [ Pass Failure ]
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes