Title: [263186] trunk/Tools
- Revision
- 263186
- Author
- [email protected]
- Date
- 2020-06-17 15:46:50 -0700 (Wed, 17 Jun 2020)
Log Message
REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213311
<rdar://problem/64456413>
Reviewed by Wenson Hsieh.
TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long
enough to make sure TextManipulationController gets notified about the insertion and starts observing.
* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (263185 => 263186)
--- trunk/Tools/ChangeLog 2020-06-17 22:45:38 UTC (rev 263185)
+++ trunk/Tools/ChangeLog 2020-06-17 22:46:50 UTC (rev 263186)
@@ -1,3 +1,17 @@
+2020-06-17 Sihui Liu <[email protected]>
+
+ REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=213311
+ <rdar://problem/64456413>
+
+ Reviewed by Wenson Hsieh.
+
+ TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long
+ enough to make sure TextManipulationController gets notified about the insertion and starts observing.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
+ (TestWebKitAPI::TEST):
+
2020-06-17 Aakash Jain <[email protected]>
Delete code for old ews bindings queue
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm (263185 => 263186)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-06-17 22:45:38 UTC (rev 263185)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-06-17 22:46:50 UTC (rev 263186)
@@ -2460,11 +2460,6 @@
EXPECT_STREQ("hey", firstItem.tokens[0].content.UTF8String);
EXPECT_STREQ(" dude", firstItem.tokens[1].content.UTF8String);
- __block BOOL foundNewItemAfterCompletingTextManipulation = false;
- [delegate setItemCallback:^(_WKTextManipulationItem *) {
- foundNewItemAfterCompletingTextManipulation = true;
- }];
-
done = false;
[webView _completeTextManipulationForItems:@[(_WKTextManipulationItem *)createItem(firstItem.identifier, {
{ firstItem.tokens[0].identifier, @"hello," },
@@ -2473,12 +2468,16 @@
EXPECT_EQ(errors, nil);
done = true;
}];
+ TestWebKitAPI::Util::run(&done);
+ done = false;
+ [delegate setItemCallback:^(_WKTextManipulationItem *) {
+ done = true;
+ }];
+ [webView stringByEvaluatingJavaScript:@"span = document.createElement('span'); span.textContent = ' WebKit!'; document.querySelector('b').after(span);"];
TestWebKitAPI::Util::run(&done);
- [webView stringByEvaluatingJavaScript:@"span = document.createElement('span'); span.textContent = ' WebKit!'; document.querySelector('b').after(span);"];
- [webView waitForNextPresentationUpdate];
- EXPECT_TRUE(foundNewItemAfterCompletingTextManipulation);
+ EXPECT_EQ(items.count, 2UL);
EXPECT_WK_STREQ("<p><i><b>hello,</b><span> WebKit!</span></i> world</p>", [webView stringByEvaluatingJavaScript:@"document.body.innerHTML"]);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes