Title: [104457] trunk/Source/WebCore
Revision
104457
Author
[email protected]
Date
2012-01-09 06:30:30 -0800 (Mon, 09 Jan 2012)

Log Message

Use Vector<OwnPtr> for m_viewportDependentMediaQueryResults in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=75723

Reviewed by Andreas Kling.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::~CSSStyleSelector):
(WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):
* css/CSSStyleSelector.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (104456 => 104457)


--- trunk/Source/WebCore/ChangeLog	2012-01-09 14:28:50 UTC (rev 104456)
+++ trunk/Source/WebCore/ChangeLog	2012-01-09 14:30:30 UTC (rev 104457)
@@ -1,3 +1,15 @@
+2012-01-09  Caio Marcelo de Oliveira Filho  <[email protected]>
+
+        Use Vector<OwnPtr> for m_viewportDependentMediaQueryResults in CSSStyleSelector
+        https://bugs.webkit.org/show_bug.cgi?id=75723
+
+        Reviewed by Andreas Kling.
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::~CSSStyleSelector):
+        (WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):
+        * css/CSSStyleSelector.h:
+
 2012-01-09  Alexis Menard  <[email protected]>
 
         Extend CSSValueList to allow slash separated lists.

Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (104456 => 104457)


--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-01-09 14:28:50 UTC (rev 104456)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-01-09 14:30:30 UTC (rev 104457)
@@ -479,7 +479,6 @@
 CSSStyleSelector::~CSSStyleSelector()
 {
     m_fontSelector->clearDocument();
-    deleteAllValues(m_viewportDependentMediaQueryResults);
 }
 
 CSSStyleSelector::Features::Features()
@@ -4704,7 +4703,7 @@
 
 void CSSStyleSelector::addViewportDependentMediaQueryResult(const MediaQueryExp* expr, bool result)
 {
-    m_viewportDependentMediaQueryResults.append(new MediaQueryResult(*expr, result));
+    m_viewportDependentMediaQueryResults.append(adoptPtr(new MediaQueryResult(*expr, result)));
 }
 
 bool CSSStyleSelector::affectedByViewportChange() const

Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (104456 => 104457)


--- trunk/Source/WebCore/css/CSSStyleSelector.h	2012-01-09 14:28:50 UTC (rev 104456)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h	2012-01-09 14:30:30 UTC (rev 104457)
@@ -397,7 +397,7 @@
     bool m_sameOriginOnly;
 
     RefPtr<CSSFontSelector> m_fontSelector;
-    Vector<MediaQueryResult*> m_viewportDependentMediaQueryResults;
+    Vector<OwnPtr<MediaQueryResult> > m_viewportDependentMediaQueryResults;
 
     bool m_applyPropertyToRegularStyle;
     bool m_applyPropertyToVisitedLinkStyle;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to