Title: [263259] trunk/Source/WebKit
- Revision
- 263259
- Author
- [email protected]
- Date
- 2020-06-19 05:27:23 -0700 (Fri, 19 Jun 2020)
Log Message
REGRESSION(r253360): [GTK] Page starts loading during animation in back/forward gesture
https://bugs.webkit.org/show_bug.cgi?id=205650
Patch by Alexander Mikhaylenko <[email protected]> on 2020-06-19
Reviewed by Carlos Garcia Campos.
r253360 changed the swipe gesture to start loading the page during the gesture, relying on
freezing the layer tree state to prevent unwanted redraws. However, it was implemented for
AC mode, but didn't prevent redraws in non-accelerated mode. Add a simple check to skip
redraws in this case.
* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::display): Skip drawing if layer tree state is frozen.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (263258 => 263259)
--- trunk/Source/WebKit/ChangeLog 2020-06-19 07:49:23 UTC (rev 263258)
+++ trunk/Source/WebKit/ChangeLog 2020-06-19 12:27:23 UTC (rev 263259)
@@ -1,3 +1,18 @@
+2020-06-19 Alexander Mikhaylenko <[email protected]>
+
+ REGRESSION(r253360): [GTK] Page starts loading during animation in back/forward gesture
+ https://bugs.webkit.org/show_bug.cgi?id=205650
+
+ Reviewed by Carlos Garcia Campos.
+
+ r253360 changed the swipe gesture to start loading the page during the gesture, relying on
+ freezing the layer tree state to prevent unwanted redraws. However, it was implemented for
+ AC mode, but didn't prevent redraws in non-accelerated mode. Add a simple check to skip
+ redraws in this case.
+
+ * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+ (WebKit::DrawingAreaCoordinatedGraphics::display): Skip drawing if layer tree state is frozen.
+
2020-06-19 Carlos Garcia Campos <[email protected]>
Add support for fetching registrable domains with resource load statistics
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (263258 => 263259)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2020-06-19 07:49:23 UTC (rev 263258)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2020-06-19 12:27:23 UTC (rev 263259)
@@ -696,6 +696,9 @@
ASSERT(!m_isWaitingForDidUpdate);
ASSERT(!m_inUpdateBackingStoreState);
+ if (m_layerTreeStateIsFrozen)
+ return;
+
if (m_isPaintingSuspended)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
