Title: [263272] trunk/Source/WebKit
- Revision
- 263272
- Author
- [email protected]
- Date
- 2020-06-19 09:34:18 -0700 (Fri, 19 Jun 2020)
Log Message
LibWebRTCSocketClient::sendTo is too verbose in case of error
https://bugs.webkit.org/show_bug.cgi?id=213380
Reviewed by Eric Carlson.
Only log error message if the error code is different from the previous one.
* NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
(WebKit::LibWebRTCSocketClient::sendTo):
* NetworkProcess/webrtc/LibWebRTCSocketClient.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (263271 => 263272)
--- trunk/Source/WebKit/ChangeLog 2020-06-19 16:30:08 UTC (rev 263271)
+++ trunk/Source/WebKit/ChangeLog 2020-06-19 16:34:18 UTC (rev 263272)
@@ -1,3 +1,16 @@
+2020-06-19 Youenn Fablet <[email protected]>
+
+ LibWebRTCSocketClient::sendTo is too verbose in case of error
+ https://bugs.webkit.org/show_bug.cgi?id=213380
+
+ Reviewed by Eric Carlson.
+
+ Only log error message if the error code is different from the previous one.
+
+ * NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
+ (WebKit::LibWebRTCSocketClient::sendTo):
+ * NetworkProcess/webrtc/LibWebRTCSocketClient.h:
+
2020-06-19 Chris Dumez <[email protected]>
Web Inspector: RemoteInspector::singleton() slows down MobileSafari launch
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp (263271 => 263272)
--- trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp 2020-06-19 16:30:08 UTC (rev 263271)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp 2020-06-19 16:34:18 UTC (rev 263272)
@@ -72,8 +72,8 @@
void LibWebRTCSocketClient::sendTo(const WebCore::SharedBuffer& buffer, const rtc::SocketAddress& socketAddress, const rtc::PacketOptions& options)
{
auto result = m_socket->SendTo(reinterpret_cast<const uint8_t*>(buffer.data()), buffer.size(), socketAddress, options);
- UNUSED_PARAM(result);
- RELEASE_LOG_ERROR_IF(result, Network, "LibWebRTCSocketClient::sendTo failed with error %d", m_socket->GetError());
+ RELEASE_LOG_ERROR_IF(result && m_sendError != result, Network, "LibWebRTCSocketClient::sendTo failed with error %d", m_socket->GetError());
+ m_sendError = result;
}
void LibWebRTCSocketClient::close()
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h (263271 => 263272)
--- trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h 2020-06-19 16:30:08 UTC (rev 263271)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h 2020-06-19 16:34:18 UTC (rev 263272)
@@ -64,6 +64,7 @@
Type m_type;
NetworkRTCProvider& m_rtcProvider;
std::unique_ptr<rtc::AsyncPacketSocket> m_socket;
+ int m_sendError { 0 };
};
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
