Title: [104475] trunk/Source/WebCore
- Revision
- 104475
- Author
- [email protected]
- Date
- 2012-01-09 12:17:09 -0800 (Mon, 09 Jan 2012)
Log Message
[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224
Patch by Judy Hao <[email protected]> on 2012-01-09
Reviewed by Philippe Normand.
Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.
Fixing memory leaks. So, no new test case is introduced.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (104474 => 104475)
--- trunk/Source/WebCore/ChangeLog 2012-01-09 20:15:33 UTC (rev 104474)
+++ trunk/Source/WebCore/ChangeLog 2012-01-09 20:17:09 UTC (rev 104475)
@@ -1,3 +1,18 @@
+2012-01-09 Judy Hao <[email protected]>
+
+ [GStreamer] webkitwebsrc: pad template is leaked
+ https://bugs.webkit.org/show_bug.cgi?id=74224
+
+ Reviewed by Philippe Normand.
+
+ Use a GstPadTemplate smart pointer in webkit_web_src_init to
+ avoid a memory leak.
+
+ Fixing memory leaks. So, no new test case is introduced.
+
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (webkit_web_src_init):
+
2012-01-09 Xianzhu Wang <[email protected]>
Avoid unnecessary TextureManager::reduceMemoryToLimit().
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (104474 => 104475)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2012-01-09 20:15:33 UTC (rev 104474)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2012-01-09 20:17:09 UTC (rev 104475)
@@ -212,7 +212,7 @@
static void webkit_web_src_init(WebKitWebSrc* src)
{
- GstPadTemplate* padTemplate = gst_static_pad_template_get(&srcTemplate);
+ GRefPtr<GstPadTemplate> padTemplate = adoptGRef(gst_static_pad_template_get(&srcTemplate));
WebKitWebSrcPrivate* priv = WEBKIT_WEB_SRC_GET_PRIVATE(src);
src->priv = priv;
@@ -232,7 +232,7 @@
GRefPtr<GstPad> targetPad = adoptGRef(gst_element_get_static_pad(GST_ELEMENT(priv->appsrc), "src"));
- priv->srcpad = gst_ghost_pad_new_from_template("src", targetPad.get(), padTemplate);
+ priv->srcpad = gst_ghost_pad_new_from_template("src", targetPad.get(), padTemplate.get());
gst_element_add_pad(GST_ELEMENT(src), priv->srcpad);
gst_pad_set_query_function(priv->srcpad, webKitWebSrcQuery);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
