Title: [263513] trunk/Tools
- Revision
- 263513
- Author
- [email protected]
- Date
- 2020-06-25 09:47:28 -0700 (Thu, 25 Jun 2020)
Log Message
[ews] Improve handling of invalid changelog
https://bugs.webkit.org/show_bug.cgi?id=213609
Reviewed by Jonathan Bedard.
* Scripts/webkitpy/tool/steps/validatereviewer.py:
(ValidateReviewer.run):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (263512 => 263513)
--- trunk/Tools/ChangeLog 2020-06-25 16:43:08 UTC (rev 263512)
+++ trunk/Tools/ChangeLog 2020-06-25 16:47:28 UTC (rev 263513)
@@ -1,3 +1,13 @@
+2020-06-25 Aakash Jain <[email protected]>
+
+ [ews] Improve handling of invalid changelog
+ https://bugs.webkit.org/show_bug.cgi?id=213609
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/webkitpy/tool/steps/validatereviewer.py:
+ (ValidateReviewer.run):
+
2020-06-24 Alexey Proskuryakov <[email protected]>
macOS Big Sur build fix.
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py (263512 => 263513)
--- trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py 2020-06-25 16:43:08 UTC (rev 263512)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py 2020-06-25 16:47:28 UTC (rev 263513)
@@ -50,6 +50,9 @@
return
for changelog_path in self.cached_lookup(state, "changelogs"):
changelog_entry = ChangeLog(changelog_path).latest_entry()
+ if not changelog_entry:
+ _log.error('Invalid ChangeLog at {}'.format(changelog_path))
+ sys.exit(1)
if changelog_entry.has_valid_reviewer():
continue
reviewer_text = changelog_entry.reviewer_text()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
