Title: [263607] trunk/Source/WebKit
- Revision
- 263607
- Author
- [email protected]
- Date
- 2020-06-26 18:16:22 -0700 (Fri, 26 Jun 2020)
Log Message
Crash at WebKit: __62-[WKContentView(WKInteraction) resignFirstResponderForWebView]_block_invoke
<https://webkit.org/b/213666>
<rdar://problem/64238661>
Reviewed by Darin Adler.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView resignFirstResponderForWebView]):
- Speculative fix to return early if there are no queued key
events available by the time the block runs.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (263606 => 263607)
--- trunk/Source/WebKit/ChangeLog 2020-06-27 00:13:34 UTC (rev 263606)
+++ trunk/Source/WebKit/ChangeLog 2020-06-27 01:16:22 UTC (rev 263607)
@@ -1,3 +1,16 @@
+2020-06-26 David Kilzer <[email protected]>
+
+ Crash at WebKit: __62-[WKContentView(WKInteraction) resignFirstResponderForWebView]_block_invoke
+ <https://webkit.org/b/213666>
+ <rdar://problem/64238661>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView resignFirstResponderForWebView]):
+ - Speculative fix to return early if there are no queued key
+ events available by the time the block runs.
+
2020-06-26 Wenson Hsieh <[email protected]>
[iOS] Layout tests sometimes assert under -[WKContentView hasContent]
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (263606 => 263607)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-06-27 00:13:34 UTC (rev 263606)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-06-27 01:16:22 UTC (rev 263607)
@@ -1421,7 +1421,8 @@
auto page = strongSelf->_page;
if (!page)
return;
- ASSERT(page->hasQueuedKeyEvent());
+ if (!page->hasQueuedKeyEvent())
+ return;
keyEventHandler(page->firstQueuedKeyEvent().nativeEvent(), YES);
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
