Title: [263848] trunk/Tools
- Revision
- 263848
- Author
- [email protected]
- Date
- 2020-07-02 09:31:46 -0700 (Thu, 02 Jul 2020)
Log Message
REGRESSION(r263625): run-minibrowser fails on mac
https://bugs.webkit.org/show_bug.cgi?id=213876
Patch by Philippe Normand <[email protected]> on 2020-07-02
Reviewed by Darin Adler.
* Scripts/webkitpy/port/base.py:
(Port.run_minibrowser): _run_script() expects a string as first argument. Command-line args
are passed through a keyword.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (263847 => 263848)
--- trunk/Tools/ChangeLog 2020-07-02 16:17:06 UTC (rev 263847)
+++ trunk/Tools/ChangeLog 2020-07-02 16:31:46 UTC (rev 263848)
@@ -1,3 +1,14 @@
+2020-07-02 Philippe Normand <[email protected]>
+
+ REGRESSION(r263625): run-minibrowser fails on mac
+ https://bugs.webkit.org/show_bug.cgi?id=213876
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/port/base.py:
+ (Port.run_minibrowser): _run_script() expects a string as first argument. Command-line args
+ are passed through a keyword.
+
2020-07-02 Carlos Garcia Campos <[email protected]>
Unreviewed. Fix GTK4 build
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (263847 => 263848)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-07-02 16:17:06 UTC (rev 263847)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-07-02 16:31:46 UTC (rev 263848)
@@ -1369,7 +1369,7 @@
def run_minibrowser(self, args):
# FIXME: Migrate to webkitpy based run-minibrowser. https://bugs.webkit.org/show_bug.cgi?id=213464
- return self._run_script(["old-run-minibrowser", ] + args)
+ return self._run_script("old-run-minibrowser", args=args)
@memoized
def _path_to_image_diff(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
