Title: [263895] trunk
Revision
263895
Author
[email protected]
Date
2020-07-03 07:31:56 -0700 (Fri, 03 Jul 2020)

Log Message

REGRESSION(r261779): [GTK][WPE] http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212017

Reviewed by Michael Catanzaro.

Tools:

Use the ephemeral data store when useEphemeralSession option is enabled.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::platformInitializeDataStore):

LayoutTests:

Remove expectations for tests that are now passing.

* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (263894 => 263895)


--- trunk/LayoutTests/ChangeLog	2020-07-03 14:21:33 UTC (rev 263894)
+++ trunk/LayoutTests/ChangeLog	2020-07-03 14:31:56 UTC (rev 263895)
@@ -1,3 +1,14 @@
+2020-07-03  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r261779): [GTK][WPE] http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=212017
+
+        Reviewed by Michael Catanzaro.
+
+        Remove expectations for tests that are now passing.
+
+        * platform/gtk/TestExpectations:
+
 2020-07-03  Youenn Fablet  <[email protected]>
 
         Allow registering VP9 as a VT decoder

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (263894 => 263895)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-07-03 14:21:33 UTC (rev 263894)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-07-03 14:31:56 UTC (rev 263895)
@@ -1240,9 +1240,6 @@
 webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright.html [ ImageOnlyFailure ]
 webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright-2.html [ ImageOnlyFailure ]
 
-webkit.org/b/212017 http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral-database.html [ Failure ]
-webkit.org/b/212017 http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html [ Failure ]
-
 webkit.org/b/212223 compositing/tiling/perspective-on-scroller-tile-coverage.html [ Failure ]
 
 webkit.org/b/212233 fast/repaint/iframe-on-subpixel-position.html [ Failure ]

Modified: trunk/Tools/ChangeLog (263894 => 263895)


--- trunk/Tools/ChangeLog	2020-07-03 14:21:33 UTC (rev 263894)
+++ trunk/Tools/ChangeLog	2020-07-03 14:31:56 UTC (rev 263895)
@@ -1,3 +1,15 @@
+2020-07-03  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r261779): [GTK][WPE] http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=212017
+
+        Reviewed by Michael Catanzaro.
+
+        Use the ephemeral data store when useEphemeralSession option is enabled.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::platformInitializeDataStore):
+
 2020-07-02  Alex Christensen  <[email protected]>
 
         Update Mac CMake build

Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (263894 => 263895)


--- trunk/Tools/WebKitTestRunner/TestController.cpp	2020-07-03 14:21:33 UTC (rev 263894)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2020-07-03 14:31:56 UTC (rev 263895)
@@ -3133,9 +3133,12 @@
 {
 }
 
-void TestController::platformInitializeDataStore(WKPageConfigurationRef, const TestOptions&)
+void TestController::platformInitializeDataStore(WKPageConfigurationRef configuration, const TestOptions& options)
 {
-    m_websiteDataStore = defaultWebsiteDataStore();
+    if (options.useEphemeralSession)
+        m_websiteDataStore = WKPageConfigurationGetWebsiteDataStore(configuration);
+    else
+        m_websiteDataStore = defaultWebsiteDataStore();
 }
 
 void TestController::platformCreateWebView(WKPageConfigurationRef configuration, const TestOptions& options)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to