Title: [263911] trunk/Source/WebCore
Revision
263911
Author
[email protected]
Date
2020-07-03 14:45:28 -0700 (Fri, 03 Jul 2020)

Log Message

WebCore/Sources.txt: Remove #if ENABLE_QUOTA
https://bugs.webkit.org/show_bug.cgi?id=213941

Reviewed by Sam Weinig.

* CMakeLists.txt: Move IDL-related ENABLE_QUOTA items out of "if (ENABLE_QUOTA)".
Longer term, I think our direction should be to remove most feature conditionals from
CMakeLists.txt too, just like I am doing for Sources.txt. But for now, doing just enough
of this to keep the build working. Someone can tidy this later as desired.

* Sources.txt: Remove #if ENABLE_QUOTA and sort files in with the others.
The source files themselves have conditionals, we don't need conditionals in Sources.txt,
and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.

Modified Paths

Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (263910 => 263911)


--- trunk/Source/WebCore/CMakeLists.txt	2020-07-03 21:43:59 UTC (rev 263910)
+++ trunk/Source/WebCore/CMakeLists.txt	2020-07-03 21:45:28 UTC (rev 263911)
@@ -1466,19 +1466,19 @@
         Modules/quota/StorageQuota.cpp
         Modules/quota/WorkerNavigatorStorageQuota.cpp
     )
-
-    list(APPEND WebCore_IDL_FILES
-        Modules/quota/DOMWindowQuota.idl
-        Modules/quota/NavigatorStorageQuota.idl
-        Modules/quota/StorageErrorCallback.idl
-        Modules/quota/StorageInfo.idl
-        Modules/quota/StorageQuota.idl
-        Modules/quota/StorageQuotaCallback.idl
-        Modules/quota/StorageUsageCallback.idl
-        Modules/quota/WorkerNavigatorStorageQuota.idl
-    )
 endif ()
 
+list(APPEND WebCore_IDL_FILES
+    Modules/quota/DOMWindowQuota.idl
+    Modules/quota/NavigatorStorageQuota.idl
+    Modules/quota/StorageErrorCallback.idl
+    Modules/quota/StorageInfo.idl
+    Modules/quota/StorageQuota.idl
+    Modules/quota/StorageQuotaCallback.idl
+    Modules/quota/StorageUsageCallback.idl
+    Modules/quota/WorkerNavigatorStorageQuota.idl
+)
+
 if (ENABLE_GRAPHICS_CONTEXT_GL)
     list(APPEND WebCore_SOURCES
         platform/graphics/ANGLEWebKitBridge.cpp

Modified: trunk/Source/WebCore/ChangeLog (263910 => 263911)


--- trunk/Source/WebCore/ChangeLog	2020-07-03 21:43:59 UTC (rev 263910)
+++ trunk/Source/WebCore/ChangeLog	2020-07-03 21:45:28 UTC (rev 263911)
@@ -1,5 +1,21 @@
 2020-07-03  Darin Adler  <[email protected]>
 
+        WebCore/Sources.txt: Remove #if ENABLE_QUOTA
+        https://bugs.webkit.org/show_bug.cgi?id=213941
+
+        Reviewed by Sam Weinig.
+
+        * CMakeLists.txt: Move IDL-related ENABLE_QUOTA items out of "if (ENABLE_QUOTA)".
+        Longer term, I think our direction should be to remove most feature conditionals from
+        CMakeLists.txt too, just like I am doing for Sources.txt. But for now, doing just enough
+        of this to keep the build working. Someone can tidy this later as desired.
+
+        * Sources.txt: Remove #if ENABLE_QUOTA and sort files in with the others.
+        The source files themselves have conditionals, we don't need conditionals in Sources.txt,
+        and we are moving towards removing the capability for #if ENABLE in the Sources.txt file.
+
+2020-07-03  Darin Adler  <[email protected]>
+
         WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD
         https://bugs.webkit.org/show_bug.cgi?id=213936
 

Modified: trunk/Source/WebCore/Sources.txt (263910 => 263911)


--- trunk/Source/WebCore/Sources.txt	2020-07-03 21:43:59 UTC (rev 263910)
+++ trunk/Source/WebCore/Sources.txt	2020-07-03 21:45:28 UTC (rev 263911)
@@ -2908,6 +2908,7 @@
 JSDOMWindowCaches.cpp
 JSDOMWindowFetch.cpp
 JSDOMWindowIndexedDatabase.cpp
+JSDOMWindowQuota.cpp
 JSDOMWindowSpeechSynthesis.cpp
 JSDOMWindowWebDatabase.cpp
 JSDataTransfer.cpp
@@ -3205,6 +3206,7 @@
 JSNavigatorMediaDevices.cpp
 JSNavigatorOnLine.cpp
 JSNavigatorShare.cpp
+JSNavigatorStorageQuota.cpp
 JSShareData.cpp
 JSNavigatorServiceWorker.cpp
 JSNavigatorWebDriver.cpp
@@ -3522,7 +3524,12 @@
 JSSpeechSynthesisVoice.cpp
 JSStaticRange.cpp
 JSStorage.cpp
+JSStorageErrorCallback.cpp
 JSStorageEvent.cpp
+JSStorageInfo.cpp
+JSStorageQuota.cpp
+JSStorageQuotaCallback.cpp
+JSStorageUsageCallback.cpp
 JSStringCallback.cpp
 JSStyleMedia.cpp
 JSStylePropertyMap.cpp
@@ -3607,6 +3614,7 @@
 JSWorkerLocation.cpp
 JSWorkerNavigator.cpp
 JSWorkerNavigatorGPU.cpp
+JSWorkerNavigatorStorageQuota.cpp
 JSWorkerType.cpp
 JSWritableStream.cpp
 JSXMLDocument.cpp
@@ -3753,19 +3761,6 @@
 JSVideoTrack.cpp
 JSVideoTrackList.cpp
 
-#if ENABLE_QUOTA
-
-JSDOMWindowQuota.cpp
-JSNavigatorStorageQuota.cpp
-JSStorageErrorCallback.cpp
-JSStorageInfo.cpp
-JSStorageQuota.cpp
-JSStorageQuotaCallback.cpp
-JSStorageUsageCallback.cpp
-JSWorkerNavigatorStorageQuota.cpp
-
-#endif
-
 #if ENABLE_USER_MESSAGE_HANDLERS
 
 JSUserMessageHandler.cpp
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to