Title: [263995] trunk/Source/WebCore
- Revision
- 263995
- Author
- [email protected]
- Date
- 2020-07-06 16:27:56 -0700 (Mon, 06 Jul 2020)
Log Message
[iOS] WAKWindow should override -resignFirstResponder and clear state
https://bugs.webkit.org/show_bug.cgi?id=214011
<rdar://problem/65152410>
Reviewed by Tim Horton.
This is part of the fix for <rdar://problem/62615273>.
Override -resignFirstResponder to clear out internal state that tracks the first responder
in the iOS Legacy WebKit world.
* platform/ios/wak/WAKWindow.mm:
(-[WAKWindow resignFirstResponder]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (263994 => 263995)
--- trunk/Source/WebCore/ChangeLog 2020-07-06 23:14:23 UTC (rev 263994)
+++ trunk/Source/WebCore/ChangeLog 2020-07-06 23:27:56 UTC (rev 263995)
@@ -1,3 +1,19 @@
+2020-07-06 Daniel Bates <[email protected]>
+
+ [iOS] WAKWindow should override -resignFirstResponder and clear state
+ https://bugs.webkit.org/show_bug.cgi?id=214011
+ <rdar://problem/65152410>
+
+ Reviewed by Tim Horton.
+
+ This is part of the fix for <rdar://problem/62615273>.
+
+ Override -resignFirstResponder to clear out internal state that tracks the first responder
+ in the iOS Legacy WebKit world.
+
+ * platform/ios/wak/WAKWindow.mm:
+ (-[WAKWindow resignFirstResponder]):
+
2020-07-06 Sam Weinig <[email protected]>
REGRESSION: (r263977): [ iOS Debug WK2 ] 36 fast form and web-platform test consistently crashing
Modified: trunk/Source/WebCore/platform/ios/wak/WAKWindow.mm (263994 => 263995)
--- trunk/Source/WebCore/platform/ios/wak/WAKWindow.mm 2020-07-06 23:14:23 UTC (rev 263994)
+++ trunk/Source/WebCore/platform/ios/wak/WAKWindow.mm 2020-07-06 23:27:56 UTC (rev 263995)
@@ -209,6 +209,18 @@
return (NSSelectionDirection)0;
}
+- (BOOL)resignFirstResponder
+{
+ BOOL shouldResign = [super resignFirstResponder];
+ if (shouldResign && _responderView && WKViewResignFirstResponder([_responderView _viewRef])) {
+ _nextResponder = nil;
+ [_responderView release];
+ _responderView = nil;
+ return YES;
+ }
+ return NO;
+}
+
- (BOOL)makeFirstResponder:(NSResponder *)aResponder
{
if (![aResponder isKindOfClass:[WAKView class]])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
