Title: [264001] trunk/Source/WebCore
Revision
264001
Author
[email protected]
Date
2020-07-06 17:15:28 -0700 (Mon, 06 Jul 2020)

Log Message

Follow-up to r263992: Make isKinjaLoginAvatarElement() a free function
https://bugs.webkit.org/show_bug.cgi?id=214015
<rdar://problem/65153632>

Unreviewed follow-up to a quirk. Just changing
isKinjaLoginAvatarElement() from member to free function.

As requested in https://bugs.webkit.org/show_bug.cgi?id=213910#c10.


* page/Quirks.cpp:
(WebCore::isKinjaLoginAvatarElement):
(WebCore::Quirks::isKinjaLoginAvatarElement const): Deleted.
* page/Quirks.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (264000 => 264001)


--- trunk/Source/WebCore/ChangeLog	2020-07-07 00:09:17 UTC (rev 264000)
+++ trunk/Source/WebCore/ChangeLog	2020-07-07 00:15:28 UTC (rev 264001)
@@ -1,3 +1,19 @@
+2020-07-06  John Wilander  <[email protected]>
+
+        Follow-up to r263992: Make isKinjaLoginAvatarElement() a free function
+        https://bugs.webkit.org/show_bug.cgi?id=214015
+        <rdar://problem/65153632>
+
+        Unreviewed follow-up to a quirk. Just changing
+        isKinjaLoginAvatarElement() from member to free function.
+
+        As requested in https://bugs.webkit.org/show_bug.cgi?id=213910#c10.
+
+        * page/Quirks.cpp:
+        (WebCore::isKinjaLoginAvatarElement):
+        (WebCore::Quirks::isKinjaLoginAvatarElement const): Deleted.
+        * page/Quirks.h:
+
 2020-07-06  Chris Fleizach  <[email protected]>
 
         AX: Implement user action spec for Escape action

Modified: trunk/Source/WebCore/page/Quirks.cpp (264000 => 264001)


--- trunk/Source/WebCore/page/Quirks.cpp	2020-07-07 00:09:17 UTC (rev 264000)
+++ trunk/Source/WebCore/page/Quirks.cpp	2020-07-07 00:15:28 UTC (rev 264001)
@@ -852,7 +852,7 @@
 }
 
 #if ENABLE(RESOURCE_LOAD_STATISTICS)
-bool Quirks::isKinjaLoginAvatarElement(const Element& element) const
+static bool isKinjaLoginAvatarElement(const Element& element)
 {
     // The click event handler has been found to trigger on a div or
     // span with these class names, or the svg, or the svg's path.

Modified: trunk/Source/WebCore/page/Quirks.h (264000 => 264001)


--- trunk/Source/WebCore/page/Quirks.h	2020-07-07 00:09:17 UTC (rev 264000)
+++ trunk/Source/WebCore/page/Quirks.h	2020-07-07 00:15:28 UTC (rev 264001)
@@ -116,10 +116,6 @@
     bool isGoogleMaps() const;
 #endif
 
-#if ENABLE(RESOURCE_LOAD_STATISTICS)
-    bool isKinjaLoginAvatarElement(const Element&) const;
-#endif
-
     WeakPtr<Document> m_document;
 
     mutable Optional<bool> m_hasBrokenEncryptedMediaAPISupportQuirk;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to