Title: [264091] releases/WebKitGTK/webkit-2.28/Source/WebKit
- Revision
- 264091
- Author
- [email protected]
- Date
- 2020-07-08 03:07:59 -0700 (Wed, 08 Jul 2020)
Log Message
Merge r263899 - [WPE][GTK] Bubblewrap sandbox should not attempt to bind empty paths
https://bugs.webkit.org/show_bug.cgi?id=202880
Patch by Michael Catanzaro <[email protected]> on 2020-07-03
Reviewed by Carlos Garcia Campos.
If an empty path is set in LD_LIBRARY_PATH (e.g. /foo::/bar), we wind up passing
--ro-bind-try --ro-bind-try to bwrap, where the second --ro-bind-try is treated as the
source path to mount, and the next flag we pass gets treated as the destination path. The
web process crashes with this confusing error:
bwrap: Can't create file at /.flatpak-info: Read-only file system
* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindIfExists):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog (264090 => 264091)
--- releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog 2020-07-08 10:07:54 UTC (rev 264090)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog 2020-07-08 10:07:59 UTC (rev 264091)
@@ -1,3 +1,20 @@
+2020-07-03 Michael Catanzaro <[email protected]>
+
+ [WPE][GTK] Bubblewrap sandbox should not attempt to bind empty paths
+ https://bugs.webkit.org/show_bug.cgi?id=202880
+
+ Reviewed by Carlos Garcia Campos.
+
+ If an empty path is set in LD_LIBRARY_PATH (e.g. /foo::/bar), we wind up passing
+ --ro-bind-try --ro-bind-try to bwrap, where the second --ro-bind-try is treated as the
+ source path to mount, and the next flag we pass gets treated as the destination path. The
+ web process crashes with this confusing error:
+
+ bwrap: Can't create file at /.flatpak-info: Read-only file system
+
+ * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+ (WebKit::bindIfExists):
+
2020-05-28 Lauro Moura <[email protected]>
[GTK][WPE] Buildfix after r262242
Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (264090 => 264091)
--- releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp 2020-07-08 10:07:54 UTC (rev 264090)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp 2020-07-08 10:07:59 UTC (rev 264091)
@@ -276,7 +276,7 @@
static void bindIfExists(Vector<CString>& args, const char* path, BindFlags bindFlags = BindFlags::ReadOnly)
{
- if (!path)
+ if (!path || path[0] == '\0')
return;
const char* bindType;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
