Title: [264088] releases/WebKitGTK/webkit-2.28/Source/WebCore
- Revision
- 264088
- Author
- [email protected]
- Date
- 2020-07-08 03:07:46 -0700 (Wed, 08 Jul 2020)
Log Message
Merge r261680 - [GStreamer] Can't replay blob videos in web.whatsapp.com
https://bugs.webkit.org/show_bug.cgi?id=192540
Patch by Philippe Normand <[email protected]> on 2020-05-14
Reviewed by Xabier Rodriguez-Calvar.
This is a variant of bug 211627 but I could reproduce it only for videos. Unfortunately I
wasn't able to write a reliable test for this.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateBufferingStatus): Prevent the fill timer from
running forever after buffering completed.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcMakeRequest): Don't buffer blobs, this doesn't seem useful as they're already
in memory anyway.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (264087 => 264088)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-07-08 10:07:41 UTC (rev 264087)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog 2020-07-08 10:07:46 UTC (rev 264088)
@@ -1,3 +1,20 @@
+2020-05-14 Philippe Normand <[email protected]>
+
+ [GStreamer] Can't replay blob videos in web.whatsapp.com
+ https://bugs.webkit.org/show_bug.cgi?id=192540
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ This is a variant of bug 211627 but I could reproduce it only for videos. Unfortunately I
+ wasn't able to write a reliable test for this.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::updateBufferingStatus): Prevent the fill timer from
+ running forever after buffering completed.
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (webKitWebSrcMakeRequest): Don't buffer blobs, this doesn't seem useful as they're already
+ in memory anyway.
+
2020-05-12 Philippe Normand <[email protected]>
[GStreamer] Audio messages in web.whatsapp.com only play once.
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (264087 => 264088)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-07-08 10:07:41 UTC (rev 264087)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-07-08 10:07:46 UTC (rev 264088)
@@ -2402,6 +2402,8 @@
if (!m_didDownloadFinish)
m_isBuffering = true;
+ else
+ m_fillTimer.stop();
m_bufferingPercentage = percentage;
switch (mode) {
Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (264087 => 264088)
--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2020-07-08 10:07:41 UTC (rev 264087)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2020-07-08 10:07:46 UTC (rev 264088)
@@ -697,8 +697,6 @@
members->loader = members->player->createResourceLoader();
PlatformMediaResourceLoader::LoadOptions loadOptions = 0;
- if (request.url().protocolIsBlob())
- loadOptions |= PlatformMediaResourceLoader::LoadOption::BufferData;
members->resource = members->loader->requestResource(ResourceRequest(request), loadOptions);
if (members->resource) {
members->resource->setClient(makeUnique<CachedResourceStreamingClient>(protector.get(), ResourceRequest(request), requestNumber));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
