Title: [264106] trunk/Tools
- Revision
- 264106
- Author
- [email protected]
- Date
- 2020-07-08 09:43:37 -0700 (Wed, 08 Jul 2020)
Log Message
Flaky API Test: TestWebKitAPI.SleepDisabler.NavigateBack
https://bugs.webkit.org/show_bug.cgi?id=213513
<rdar://problem/64642715>
Reviewed by Eric Carlson.
Make the test less dependent on the specific behavior of restoring the history state by adding code within
the source HTML itself to explicitly play the contained video after state restoration.
* TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
(TEST_F):
* TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264105 => 264106)
--- trunk/Tools/ChangeLog 2020-07-08 16:42:54 UTC (rev 264105)
+++ trunk/Tools/ChangeLog 2020-07-08 16:43:37 UTC (rev 264106)
@@ -1,3 +1,18 @@
+2020-07-08 Jer Noble <[email protected]>
+
+ Flaky API Test: TestWebKitAPI.SleepDisabler.NavigateBack
+ https://bugs.webkit.org/show_bug.cgi?id=213513
+ <rdar://problem/64642715>
+
+ Reviewed by Eric Carlson.
+
+ Make the test less dependent on the specific behavior of restoring the history state by adding code within
+ the source HTML itself to explicitly play the contained video after state restoration.
+
+ * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
+ (TEST_F):
+ * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
+
2020-07-07 Antoine Quint <[email protected]>
[iOS] Sharing an <img> element with a base64-encoded URL shares the URL as raw text instead of an image
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/SleepDisabler.mm (264105 => 264106)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/SleepDisabler.mm 2020-07-08 16:42:54 UTC (rev 264105)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/SleepDisabler.mm 2020-07-08 16:43:37 UTC (rev 264106)
@@ -214,7 +214,6 @@
hasSleepDisablerShouldBecomeEqualTo(false);
[webView goBack];
- [webView evaluateJavaScript:@"document.querySelector('video').play()" completionHandler:nil];
hasSleepDisablerShouldBecomeEqualTo(true);
}
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html (264105 => 264106)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html 2020-07-08 16:42:54 UTC (rev 264105)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html 2020-07-08 16:43:37 UTC (rev 264106)
@@ -28,6 +28,8 @@
window.webkit.messageHandlers.testHandler.postMessage('not playing');
} catch(e) { }
}
+
+ document.addEventListener('pageshow', go);
</script>
</head>
<body _onload_="go()">
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
