Title: [264161] trunk/Source/WebCore
- Revision
- 264161
- Author
- [email protected]
- Date
- 2020-07-09 01:29:35 -0700 (Thu, 09 Jul 2020)
Log Message
[MSE][GStreamer] Remove orphan code in SourceBufferPrivateGStreamer::append()
https://bugs.webkit.org/show_bug.cgi?id=214086
Reviewed by Xabier Rodriguez-Calvar.
A refactor in r240784 missed this line, which was unreachable code
before and should have removed.
Instead, it has been run every time after sending an append to the
AppendPipeline, and it just happens it doesn't have visible
consequences.
This patch cleans that up removing that line. No visible behavior
changes are introduced.
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::append):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264160 => 264161)
--- trunk/Source/WebCore/ChangeLog 2020-07-09 08:23:36 UTC (rev 264160)
+++ trunk/Source/WebCore/ChangeLog 2020-07-09 08:29:35 UTC (rev 264161)
@@ -1,3 +1,23 @@
+2020-07-09 Alicia Boya García <[email protected]>
+
+ [MSE][GStreamer] Remove orphan code in SourceBufferPrivateGStreamer::append()
+ https://bugs.webkit.org/show_bug.cgi?id=214086
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ A refactor in r240784 missed this line, which was unreachable code
+ before and should have removed.
+
+ Instead, it has been run every time after sending an append to the
+ AppendPipeline, and it just happens it doesn't have visible
+ consequences.
+
+ This patch cleans that up removing that line. No visible behavior
+ changes are introduced.
+
+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
+ (WebCore::SourceBufferPrivateGStreamer::append):
+
2020-07-09 Carlos Garcia Campos <[email protected]>
[SOUP] Initialize m_allowCookies and m_acceptEncoding in ResourceRequest::updateFromSoupMessage
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp (264160 => 264161)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp 2020-07-09 08:23:36 UTC (rev 264160)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp 2020-07-09 08:29:35 UTC (rev 264161)
@@ -78,7 +78,6 @@
return;
m_client->append(this, WTFMove(data));
- m_sourceBufferPrivateClient->sourceBufferPrivateAppendComplete(SourceBufferPrivateClient::ReadStreamFailed);
}
void SourceBufferPrivateGStreamer::abort()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
