Title: [264237] trunk/Source/WebCore
- Revision
- 264237
- Author
- peng.l...@apple.com
- Date
- 2020-07-10 13:13:33 -0700 (Fri, 10 Jul 2020)
Log Message
MobileSafari rotates its scene to portrait upside down if it has a PiP on screen
https://bugs.webkit.org/show_bug.cgi?id=214169
Reviewed by Jer Noble.
The UIViewController for video fullscreen/picture-in-picture should not ignore
the App's supported orientations when the video element is in picture-in-picture.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::doSetup):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264236 => 264237)
--- trunk/Source/WebCore/ChangeLog 2020-07-10 20:04:20 UTC (rev 264236)
+++ trunk/Source/WebCore/ChangeLog 2020-07-10 20:13:33 UTC (rev 264237)
@@ -1,3 +1,16 @@
+2020-07-10 Peng Liu <peng.l...@apple.com>
+
+ MobileSafari rotates its scene to portrait upside down if it has a PiP on screen
+ https://bugs.webkit.org/show_bug.cgi?id=214169
+
+ Reviewed by Jer Noble.
+
+ The UIViewController for video fullscreen/picture-in-picture should not ignore
+ the App's supported orientations when the video element is in picture-in-picture.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (VideoFullscreenInterfaceAVKit::doSetup):
+
2020-07-10 Don Olmstead <don.olmst...@sony.com> and Fujii Hironori <hironori.fu...@sony.com>
[WinCairo] WOFF2 font support
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (264236 => 264237)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-07-10 20:04:20 UTC (rev 264236)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2020-07-10 20:13:33 UTC (rev 264237)
@@ -1078,6 +1078,7 @@
LOG(Fullscreen, "VideoFullscreenInterfaceAVKit::didStartPictureInPicture(%p)", this);
setMode(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture);
[m_playerViewController setShowsPlaybackControls:YES];
+ [m_viewController _setIgnoreAppSupportedOrientations:NO];
if (m_currentMode.hasFullscreen()) {
m_shouldReturnToFullscreenWhenStoppingPiP = YES;
@@ -1140,6 +1141,7 @@
{
LOG(Fullscreen, "VideoFullscreenInterfaceAVKit::didStopPictureInPicture(%p)", this);
m_targetMode.setPictureInPicture(false);
+ [m_viewController _setIgnoreAppSupportedOrientations:YES];
if (m_currentMode.hasFullscreen() || m_restoringFullscreenForPictureInPictureStop) {
clearMode(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
