Title: [264266] trunk/Source/WebKit
- Revision
- 264266
- Author
- [email protected]
- Date
- 2020-07-10 23:30:24 -0700 (Fri, 10 Jul 2020)
Log Message
[iOS] Prompt for requestStorageAccess is inverted in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=214198
<rdar://problem/65369725>
Reviewed by Darin Adler.
The labels for "allow" and "deny" StorageAccess API were inverted in the WKWebView
implementation.
* UIProcess/Cocoa/WKStorageAccessAlert.mm:
(WebKit::presentStorageAccessAlert):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264265 => 264266)
--- trunk/Source/WebKit/ChangeLog 2020-07-11 05:40:21 UTC (rev 264265)
+++ trunk/Source/WebKit/ChangeLog 2020-07-11 06:30:24 UTC (rev 264266)
@@ -1,3 +1,17 @@
+2020-07-10 Brent Fulgham <[email protected]>
+
+ [iOS] Prompt for requestStorageAccess is inverted in WKWebView
+ https://bugs.webkit.org/show_bug.cgi?id=214198
+ <rdar://problem/65369725>
+
+ Reviewed by Darin Adler.
+
+ The labels for "allow" and "deny" StorageAccess API were inverted in the WKWebView
+ implementation.
+
+ * UIProcess/Cocoa/WKStorageAccessAlert.mm:
+ (WebKit::presentStorageAccessAlert):
+
2020-07-10 Wenson Hsieh <[email protected]>
[iOS] Prevent SPI clients from making the minimum layout height or width negative
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm (264265 => 264266)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm 2020-07-11 05:40:21 UTC (rev 264265)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm 2020-07-11 06:30:24 UTC (rev 264266)
@@ -67,12 +67,12 @@
#else
UIAlertController* alert = [UIAlertController alertControllerWithTitle:alertTitle message:informativeText preferredStyle:UIAlertControllerStyleAlert];
- UIAlertAction* doNotAllowAction = [UIAlertAction actionWithTitle:allowButtonString style:UIAlertActionStyleCancel handler:[completionBlock](UIAlertAction *action) {
- completionBlock(false);
+ UIAlertAction* allowAction = [UIAlertAction actionWithTitle:allowButtonString style:UIAlertActionStyleCancel handler:[completionBlock](UIAlertAction *action) {
+ completionBlock(true);
}];
- UIAlertAction* allowAction = [UIAlertAction actionWithTitle:doNotAllowButtonString style:UIAlertActionStyleDefault handler:[completionBlock](UIAlertAction *action) {
- completionBlock(true);
+ UIAlertAction* doNotAllowAction = [UIAlertAction actionWithTitle:doNotAllowButtonString style:UIAlertActionStyleDefault handler:[completionBlock](UIAlertAction *action) {
+ completionBlock(false);
}];
[alert addAction:doNotAllowAction];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
