Title: [264309] trunk/Source/WebKit
- Revision
- 264309
- Author
- [email protected]
- Date
- 2020-07-13 12:13:04 -0700 (Mon, 13 Jul 2020)
Log Message
Crash under WebKit::LaunchServicesDatabaseManager::didConnect()
https://bugs.webkit.org/show_bug.cgi?id=214263
Reviewed by Darin Adler.
There is a crash under WebKit::LaunchServicesDatabaseManager::didConnect() when trying to send a message to an invalid connection.
No new tests, since I have not been able to reproduce.
* WebProcess/cocoa/LaunchServicesDatabaseManager.mm:
(WebKit::LaunchServicesDatabaseManager::didConnect):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264308 => 264309)
--- trunk/Source/WebKit/ChangeLog 2020-07-13 19:09:33 UTC (rev 264308)
+++ trunk/Source/WebKit/ChangeLog 2020-07-13 19:13:04 UTC (rev 264309)
@@ -1,3 +1,17 @@
+2020-07-13 Per Arne Vollan <[email protected]>
+
+ Crash under WebKit::LaunchServicesDatabaseManager::didConnect()
+ https://bugs.webkit.org/show_bug.cgi?id=214263
+
+ Reviewed by Darin Adler.
+
+ There is a crash under WebKit::LaunchServicesDatabaseManager::didConnect() when trying to send a message to an invalid connection.
+
+ No new tests, since I have not been able to reproduce.
+
+ * WebProcess/cocoa/LaunchServicesDatabaseManager.mm:
+ (WebKit::LaunchServicesDatabaseManager::didConnect):
+
2020-07-13 Brent Fulgham <[email protected]>
REGRESSION (r262538): Nullptr Deref in WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::performDailyTasks()::$_66, void>::call
Modified: trunk/Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm (264308 => 264309)
--- trunk/Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm 2020-07-13 19:09:33 UTC (rev 264308)
+++ trunk/Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm 2020-07-13 19:13:04 UTC (rev 264309)
@@ -67,7 +67,11 @@
auto message = adoptOSObject(xpc_dictionary_create(nullptr, nullptr, 0));
xpc_dictionary_set_string(message.get(), XPCEndpoint::xpcMessageNameKey, LaunchServicesDatabaseXPCConstants::xpcRequestLaunchServicesDatabaseUpdateMessageName);
- xpc_connection_send_message(connection().get(), message.get());
+ auto connection = this->connection();
+ if (!connection)
+ return;
+
+ xpc_connection_send_message(connection.get(), message.get());
}
bool LaunchServicesDatabaseManager::waitForDatabaseUpdate(Seconds timeout)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
