Title: [264324] trunk
- Revision
- 264324
- Author
- [email protected]
- Date
- 2020-07-13 16:23:55 -0700 (Mon, 13 Jul 2020)
Log Message
[JSC] IntlLocale::initializeLocale should have scope.release
https://bugs.webkit.org/show_bug.cgi?id=214271
<rdar://problem/65467314>
Reviewed by Darin Adler.
JSTests:
* stress/intl-locale.js:
Source/_javascript_Core:
Add missing scope.release() to suppress validateExceptionChecks crash.
* runtime/IntlLocale.cpp:
(JSC::IntlLocale::initializeLocale):
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (264323 => 264324)
--- trunk/JSTests/ChangeLog 2020-07-13 23:15:18 UTC (rev 264323)
+++ trunk/JSTests/ChangeLog 2020-07-13 23:23:55 UTC (rev 264324)
@@ -1,5 +1,15 @@
2020-07-13 Yusuke Suzuki <[email protected]>
+ [JSC] IntlLocale::initializeLocale should have scope.release
+ https://bugs.webkit.org/show_bug.cgi?id=214271
+ <rdar://problem/65467314>
+
+ Reviewed by Darin Adler.
+
+ * stress/intl-locale.js:
+
+2020-07-13 Yusuke Suzuki <[email protected]>
+
[JSC] FTL isCellOrMisc should be isCellOrMiscOrBigInt32
https://bugs.webkit.org/show_bug.cgi?id=214269
<rdar://problem/65475129>
Modified: trunk/JSTests/stress/intl-locale.js (264323 => 264324)
--- trunk/JSTests/stress/intl-locale.js 2020-07-13 23:15:18 UTC (rev 264323)
+++ trunk/JSTests/stress/intl-locale.js 2020-07-13 23:23:55 UTC (rev 264324)
@@ -44,6 +44,7 @@
shouldThrow(() => new Intl.Locale(['en', 'ja']), RangeError);
shouldThrow(() => new Intl.Locale({}), RangeError);
shouldThrow(() => new Intl.Locale({ toString() { throw new Error(); } }), Error);
+shouldThrow(() => new Intl.Locale([]), RangeError);
shouldNotThrow(() => new Intl.Locale({ toString() { return 'en'; } }));
shouldThrow(() => new Intl.Locale('en', null), TypeError);
Modified: trunk/Source/_javascript_Core/ChangeLog (264323 => 264324)
--- trunk/Source/_javascript_Core/ChangeLog 2020-07-13 23:15:18 UTC (rev 264323)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-07-13 23:23:55 UTC (rev 264324)
@@ -1,5 +1,18 @@
2020-07-13 Yusuke Suzuki <[email protected]>
+ [JSC] IntlLocale::initializeLocale should have scope.release
+ https://bugs.webkit.org/show_bug.cgi?id=214271
+ <rdar://problem/65467314>
+
+ Reviewed by Darin Adler.
+
+ Add missing scope.release() to suppress validateExceptionChecks crash.
+
+ * runtime/IntlLocale.cpp:
+ (JSC::IntlLocale::initializeLocale):
+
+2020-07-13 Yusuke Suzuki <[email protected]>
+
[JSC] FTL isCellOrMisc should be isCellOrMiscOrBigInt32
https://bugs.webkit.org/show_bug.cgi?id=214269
<rdar://problem/65475129>
Modified: trunk/Source/_javascript_Core/runtime/IntlLocale.cpp (264323 => 264324)
--- trunk/Source/_javascript_Core/runtime/IntlLocale.cpp 2020-07-13 23:15:18 UTC (rev 264323)
+++ trunk/Source/_javascript_Core/runtime/IntlLocale.cpp 2020-07-13 23:23:55 UTC (rev 264324)
@@ -220,6 +220,7 @@
String tag = tagValue.inherits<IntlLocale>(vm) ? jsCast<IntlLocale*>(tagValue)->toString() : tagValue.toWTFString(globalObject);
RETURN_IF_EXCEPTION(scope, void());
+ scope.release();
initializeLocale(globalObject, tag, optionsValue);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
