Title: [264407] trunk/Source
- Revision
- 264407
- Author
- [email protected]
- Date
- 2020-07-15 11:17:44 -0700 (Wed, 15 Jul 2020)
Log Message
Building AccessibilitySupportSPI with the macOS Big Sur public SDK fails
https://bugs.webkit.org/show_bug.cgi?id=214237
Patch by Rob Buis <[email protected]> on 2020-07-15
Reviewed by Alex Christensen.
Source/WebCore/PAL:
We need to include CoreFoundation.h header here to use CF_ENUM, since
we can't rely on the call site that includes AccessibilitySupportSPI.h
doing it for us.
We also need to declare _AXSetClientIdentificationOverride since it
it is used by AccessibilityController.cpp.
* pal/spi/cocoa/AccessibilitySupportSPI.h:
* pal/spi/mac/HIServicesSPI.h:
Source/WebKit:
Need to include HIServicesSPI.h for _AXUIElementRequestServicedBySecondaryAXThread.
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (264406 => 264407)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-07-15 18:03:15 UTC (rev 264406)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-07-15 18:17:44 UTC (rev 264407)
@@ -1,3 +1,19 @@
+2020-07-15 Rob Buis <[email protected]>
+
+ Building AccessibilitySupportSPI with the macOS Big Sur public SDK fails
+ https://bugs.webkit.org/show_bug.cgi?id=214237
+
+ Reviewed by Alex Christensen.
+
+ We need to include CoreFoundation.h header here to use CF_ENUM, since
+ we can't rely on the call site that includes AccessibilitySupportSPI.h
+ doing it for us.
+ We also need to declare _AXSetClientIdentificationOverride since it
+ it is used by AccessibilityController.cpp.
+
+ * pal/spi/cocoa/AccessibilitySupportSPI.h:
+ * pal/spi/mac/HIServicesSPI.h:
+
2020-07-15 Brady Eidson <[email protected]>
Fix some build configurations after r264389
Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSPI.h (264406 => 264407)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSPI.h 2020-07-15 18:03:15 UTC (rev 264406)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AccessibilitySupportSPI.h 2020-07-15 18:17:44 UTC (rev 264407)
@@ -31,6 +31,8 @@
#else
+#include <CoreFoundation/CoreFoundation.h>
+
WTF_EXTERN_C_BEGIN
#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
Modified: trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (264406 => 264407)
--- trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h 2020-07-15 18:03:15 UTC (rev 264406)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h 2020-07-15 18:17:44 UTC (rev 264407)
@@ -33,6 +33,8 @@
#else
+#include <ApplicationServices/ApplicationServices.h>
+
typedef CF_ENUM(SInt32, CoreCursorType) {
kCoreCursorFirstCursor = 0,
kCoreCursorArrow = kCoreCursorFirstCursor,
@@ -144,6 +146,7 @@
kAXClientTypeDictation,
};
AXClientType _AXGetClientForCurrentRequestUntrusted(void);
+void _AXSetClientIdentificationOverride(AXClientType);
#endif // HAVE(AX_CLIENT_TYPE)
WTF_EXTERN_C_END
Modified: trunk/Source/WebKit/ChangeLog (264406 => 264407)
--- trunk/Source/WebKit/ChangeLog 2020-07-15 18:03:15 UTC (rev 264406)
+++ trunk/Source/WebKit/ChangeLog 2020-07-15 18:17:44 UTC (rev 264407)
@@ -1,3 +1,14 @@
+2020-07-15 Rob Buis <[email protected]>
+
+ Building AccessibilitySupportSPI with the macOS Big Sur public SDK fails
+ https://bugs.webkit.org/show_bug.cgi?id=214237
+
+ Reviewed by Alex Christensen.
+
+ Need to include HIServicesSPI.h for _AXUIElementRequestServicedBySecondaryAXThread.
+
+ * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
+
2020-07-15 Brady Eidson <[email protected]>
Update a WKPreferences API comment.
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm (264406 => 264407)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2020-07-15 18:03:15 UTC (rev 264406)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2020-07-15 18:17:44 UTC (rev 264407)
@@ -47,6 +47,7 @@
#import <WebCore/Scrollbar.h>
#import <WebCore/WebAccessibilityObjectWrapperMac.h>
#import <pal/spi/cocoa/NSAccessibilitySPI.h>
+#import <pal/spi/mac/HIServicesSPI.h>
#import <wtf/cocoa/VectorCocoa.h>
namespace ax = WebCore::Accessibility;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
