Title: [264428] trunk/Source
Revision
264428
Author
commit-qu...@webkit.org
Date
2020-07-15 15:14:55 -0700 (Wed, 15 Jul 2020)

Log Message

Add some missing boilerplate to help fix build on macOS Big Sur
https://bugs.webkit.org/show_bug.cgi?id=214338

Patch by Saagar Jha <saa...@saagarjha.com> on 2020-07-15
Reviewed by Darin Adler.

Source/WebCore/PAL:

* pal/spi/mac/NSAppearanceSPI.h: Add -[NSAppearance _usesMetricsAppearance] to the SPI header.
* pal/spi/mac/NSImageSPI.h: Add +[NSImage _imageWithSystemSymbolName:] to the SPI header.

Source/WTF:

* wtf/PlatformHave.h: Add HAVE_LARGE_CONTROL_SIZE and enable it on Big Sur.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (264427 => 264428)


--- trunk/Source/WTF/ChangeLog	2020-07-15 21:59:16 UTC (rev 264427)
+++ trunk/Source/WTF/ChangeLog	2020-07-15 22:14:55 UTC (rev 264428)
@@ -1,3 +1,12 @@
+2020-07-15  Saagar Jha  <saa...@saagarjha.com>
+
+        Add some missing boilerplate to help fix build on macOS Big Sur
+        https://bugs.webkit.org/show_bug.cgi?id=214338
+
+        Reviewed by Darin Adler.
+
+        * wtf/PlatformHave.h: Add HAVE_LARGE_CONTROL_SIZE and enable it on Big Sur.
+
 2020-07-15  Darin Adler  <da...@apple.com>
 
         Remove a few more uses of the terms black/white list

Modified: trunk/Source/WTF/wtf/PlatformHave.h (264427 => 264428)


--- trunk/Source/WTF/wtf/PlatformHave.h	2020-07-15 21:59:16 UTC (rev 264427)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2020-07-15 22:14:55 UTC (rev 264428)
@@ -594,6 +594,10 @@
 #define HAVE_ALTERNATE_ICONS 1
 #endif
 
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600)
+#define HAVE_LARGE_CONTROL_SIZE 1
+#endif
+
 #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)
 #define HAVE_UICONTEXTMENU_LOCATION 1
 #endif

Modified: trunk/Source/WebCore/PAL/ChangeLog (264427 => 264428)


--- trunk/Source/WebCore/PAL/ChangeLog	2020-07-15 21:59:16 UTC (rev 264427)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-07-15 22:14:55 UTC (rev 264428)
@@ -1,3 +1,13 @@
+2020-07-15  Saagar Jha  <saa...@saagarjha.com>
+
+        Add some missing boilerplate to help fix build on macOS Big Sur
+        https://bugs.webkit.org/show_bug.cgi?id=214338
+
+        Reviewed by Darin Adler.
+
+        * pal/spi/mac/NSAppearanceSPI.h: Add -[NSAppearance _usesMetricsAppearance] to the SPI header.
+        * pal/spi/mac/NSImageSPI.h: Add +[NSImage _imageWithSystemSymbolName:] to the SPI header.
+
 2020-07-15  Rob Buis  <rb...@igalia.com>
 
         Building AccessibilitySupportSPI with the macOS Big Sur public SDK fails

Modified: trunk/Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h (264427 => 264428)


--- trunk/Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h	2020-07-15 21:59:16 UTC (rev 264427)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h	2020-07-15 22:14:55 UTC (rev 264428)
@@ -34,6 +34,9 @@
 @interface NSAppearance ()
 
 - (void)_drawInRect:(NSRect)rect context:(CGContextRef)context options:(NSDictionary *)options;
+#if !USE(APPLE_INTERNAL_SDK)
+- (BOOL)_usesMetricsAppearance;
+#endif
 
 @end
 

Modified: trunk/Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h (264427 => 264428)


--- trunk/Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h	2020-07-15 21:59:16 UTC (rev 264427)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h	2020-07-15 22:14:55 UTC (rev 264428)
@@ -35,6 +35,7 @@
 
 @interface NSImage ()
 - (void)lockFocusWithRect:(NSRect)rect context:(NSGraphicsContext *)context hints:(NSDictionary *)hints flipped:(BOOL)flipped;
++ (NSImage *)_imageWithSystemSymbolName:(NSString *)name;
 @end
 
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to