Title: [264449] trunk/Source/WebCore
- Revision
- 264449
- Author
- [email protected]
- Date
- 2020-07-16 01:21:58 -0700 (Thu, 16 Jul 2020)
Log Message
REGRESSION(r264280) [GTK][WPE] fast/gradients/conic-gradient-alpha.html is failing
https://bugs.webkit.org/show_bug.cgi?id=214259
Reviewed by Darin Adler.
* platform/graphics/ColorBlending.cpp:
(WebCore::blendWithoutPremultiply): Use 'to' instead of 'from' when converting to SRGBA.
* platform/graphics/cairo/GradientCairo.cpp:
(WebCore::createConic): Use blendWithoutPremultiply() instead of blend() for the color stops interpolation.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264448 => 264449)
--- trunk/Source/WebCore/ChangeLog 2020-07-16 08:19:52 UTC (rev 264448)
+++ trunk/Source/WebCore/ChangeLog 2020-07-16 08:21:58 UTC (rev 264449)
@@ -1,5 +1,17 @@
2020-07-16 Carlos Garcia Campos <[email protected]>
+ REGRESSION(r264280) [GTK][WPE] fast/gradients/conic-gradient-alpha.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=214259
+
+ Reviewed by Darin Adler.
+
+ * platform/graphics/ColorBlending.cpp:
+ (WebCore::blendWithoutPremultiply): Use 'to' instead of 'from' when converting to SRGBA.
+ * platform/graphics/cairo/GradientCairo.cpp:
+ (WebCore::createConic): Use blendWithoutPremultiply() instead of blend() for the color stops interpolation.
+
+2020-07-16 Carlos Garcia Campos <[email protected]>
+
REGRESSION(r264272) [GTK][WPE] css3/color/composited-solid-backgrounds.html is failing
https://bugs.webkit.org/show_bug.cgi?id=214260
Modified: trunk/Source/WebCore/platform/graphics/ColorBlending.cpp (264448 => 264449)
--- trunk/Source/WebCore/platform/graphics/ColorBlending.cpp 2020-07-16 08:19:52 UTC (rev 264448)
+++ trunk/Source/WebCore/platform/graphics/ColorBlending.cpp 2020-07-16 08:21:58 UTC (rev 264449)
@@ -118,7 +118,7 @@
return { };
auto fromSRGB = from.toSRGBALossy<uint8_t>();
- auto toSRGB = from.toSRGBALossy<uint8_t>();
+ auto toSRGB = to.toSRGBALossy<uint8_t>();
return clampToComponentBytes<SRGBA>(
WebCore::blend(fromSRGB.red, toSRGB.red, progress),
Modified: trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp (264448 => 264449)
--- trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp 2020-07-16 08:19:52 UTC (rev 264448)
+++ trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp 2020-07-16 08:21:58 UTC (rev 264449)
@@ -142,7 +142,7 @@
// So add three additional interpolated stops, allowing for four Bezier curves.
if (stops.size() == 2) {
auto interpolatedStop = [&] (double fraction) -> Gradient::ColorStop {
- return { blend(stops.first().offset, stops.last().offset, fraction), blend(stops.first().color, stops.last().color, fraction) };
+ return { blend(stops.first().offset, stops.last().offset, fraction), blendWithoutPremultiply(stops.first().color, stops.last().color, fraction) };
};
stops = { stops.first(), interpolatedStop(0.25), interpolatedStop(0.5), interpolatedStop(0.75), stops.last() };
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
