Title: [264451] trunk/Tools
- Revision
- 264451
- Author
- [email protected]
- Date
- 2020-07-16 02:23:58 -0700 (Thu, 16 Jul 2020)
Log Message
run-minibrowser --debug runs the release build on macOS
https://bugs.webkit.org/show_bug.cgi?id=214397
Patch by Philippe Normand <[email protected]> on 2020-07-16
Reviewed by Žan Doberšek.
Pass-through port configuration and platform options to old-run-minibrowser. GTK and WPE
ports are not affected by this because they build the path to MiniBrowser for the given
configuration already.
Also set ignore_errors to True when invoking the Executive, to prevent useless and confusing
tracebacks raised when old-run-minibrowser exits with a positive exit code, eg, when it's
being called with the --help argument.
* Scripts/webkitpy/port/base.py:
(Port.run_minibrowser):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264450 => 264451)
--- trunk/Tools/ChangeLog 2020-07-16 09:11:31 UTC (rev 264450)
+++ trunk/Tools/ChangeLog 2020-07-16 09:23:58 UTC (rev 264451)
@@ -1,3 +1,21 @@
+2020-07-16 Philippe Normand <[email protected]>
+
+ run-minibrowser --debug runs the release build on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=214397
+
+ Reviewed by Žan Doberšek.
+
+ Pass-through port configuration and platform options to old-run-minibrowser. GTK and WPE
+ ports are not affected by this because they build the path to MiniBrowser for the given
+ configuration already.
+
+ Also set ignore_errors to True when invoking the Executive, to prevent useless and confusing
+ tracebacks raised when old-run-minibrowser exits with a positive exit code, eg, when it's
+ being called with the --help argument.
+
+ * Scripts/webkitpy/port/base.py:
+ (Port.run_minibrowser):
+
2020-07-16 Carlos Garcia Campos <[email protected]>
REGRESSION(r264272) [GTK][WPE] css3/color/composited-solid-backgrounds.html is failing
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (264450 => 264451)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-07-16 09:11:31 UTC (rev 264450)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-07-16 09:23:58 UTC (rev 264451)
@@ -1370,7 +1370,9 @@
def run_minibrowser(self, args):
# FIXME: Migrate to webkitpy based run-minibrowser. https://bugs.webkit.org/show_bug.cgi?id=213464
miniBrowser = self.path_to_script("old-run-minibrowser")
- return self._executive.run_command([miniBrowser] + args, stdout=None, cwd=self.webkit_base(), return_stderr=False, decode_output=False)
+ args.append(self._config.flag_for_configuration(self.get_option('configuration')))
+ args.append("--%s" % self.get_option('platform'))
+ return self._executive.run_command([miniBrowser] + args, stdout=None, cwd=self.webkit_base(), return_stderr=False, decode_output=False, ignore_errors=True)
@memoized
def _path_to_image_diff(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
