Title: [264455] trunk/Tools
- Revision
- 264455
- Author
- [email protected]
- Date
- 2020-07-16 09:06:02 -0700 (Thu, 16 Jul 2020)
Log Message
Improve handling of invalid ChangeLog by webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=214365
Reviewed by Jonathan Bedard.
* Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog._ensure_bug_url):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264454 => 264455)
--- trunk/Tools/ChangeLog 2020-07-16 15:32:38 UTC (rev 264454)
+++ trunk/Tools/ChangeLog 2020-07-16 16:06:02 UTC (rev 264455)
@@ -1,3 +1,13 @@
+2020-07-16 Aakash Jain <[email protected]>
+
+ Improve handling of invalid ChangeLog by webkit-patch
+ https://bugs.webkit.org/show_bug.cgi?id=214365
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/webkitpy/tool/steps/preparechangelog.py:
+ (PrepareChangeLog._ensure_bug_url):
+
2020-07-16 Jonathan Bedard <[email protected]>
[webkitcorepy] Correct url in setup.py
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py (264454 => 264455)
--- trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py 2020-07-16 15:32:38 UTC (rev 264454)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py 2020-07-16 16:06:02 UTC (rev 264455)
@@ -1,3 +1,4 @@
+# Copyright (C) 2020 Apple Inc. All rights reserved.
# Copyright (C) 2010 Google Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
@@ -55,6 +56,9 @@
changelogs = self.cached_lookup(state, "changelogs")
for changelog_path in changelogs:
changelog = ChangeLog(changelog_path, self._tool.filesystem)
+ if not changelog.latest_entry():
+ _log.error('Invalid ChangeLog at: {}'.format(changelog_path))
+ sys.exit(1)
if not changelog.latest_entry().bug_id():
changelog.set_short_description_and_bug_url(
self.cached_lookup(state, "bug_title"),
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
