Title: [264485] trunk/Source/WebKit
- Revision
- 264485
- Author
- [email protected]
- Date
- 2020-07-16 16:35:22 -0700 (Thu, 16 Jul 2020)
Log Message
[WinCairo][CURL] NetworkProcess consumes CPU resource greedily
https://bugs.webkit.org/show_bug.cgi?id=214383
Reviewed by Fujii Hironori.
Add PolicyAction::Ignore handling routine in NetworkDataTaskCurl::invokeDidReceiveResponse()
If we don't cancel the ignored requests the worker thread for curl scheduler goes busy-looping because the fds of the requests continue to be monitored.
No tests needed as existing tests cover this change.
* NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264484 => 264485)
--- trunk/Source/WebKit/ChangeLog 2020-07-16 23:33:20 UTC (rev 264484)
+++ trunk/Source/WebKit/ChangeLog 2020-07-16 23:35:22 UTC (rev 264485)
@@ -1,3 +1,18 @@
+2020-07-16 Takashi Komori <[email protected]>
+
+ [WinCairo][CURL] NetworkProcess consumes CPU resource greedily
+ https://bugs.webkit.org/show_bug.cgi?id=214383
+
+ Reviewed by Fujii Hironori.
+
+ Add PolicyAction::Ignore handling routine in NetworkDataTaskCurl::invokeDidReceiveResponse()
+ If we don't cancel the ignored requests the worker thread for curl scheduler goes busy-looping because the fds of the requests continue to be monitored.
+
+ No tests needed as existing tests cover this change.
+
+ * NetworkProcess/curl/NetworkDataTaskCurl.cpp:
+ (WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):
+
2020-07-16 Tim Horton <[email protected]>
iPad cursor is sometimes slow to change to I-beam (e.g. on reddit.com)
Modified: trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp (264484 => 264485)
--- trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp 2020-07-16 23:33:20 UTC (rev 264484)
+++ trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp 2020-07-16 23:35:22 UTC (rev 264485)
@@ -236,6 +236,7 @@
m_curlRequest->completeDidReceiveResponse();
break;
case PolicyAction::Ignore:
+ invalidateAndCancel();
break;
default:
notImplemented();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
