Title: [264518] trunk/Source/WTF
- Revision
- 264518
- Author
- [email protected]
- Date
- 2020-07-17 10:26:45 -0700 (Fri, 17 Jul 2020)
Log Message
Fix 32-bit debug watchos build
https://bugs.webkit.org/show_bug.cgi?id=214480
Reviewed by Michael Saboff.
subtracting pointers produces a ptrdiff_t but on 32-bit that's the same
as an int. Since we were comparing that to an unsigned that triggered
the signed comparison warning, which broke the build.
* wtf/text/StringParsingBuffer.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (264517 => 264518)
--- trunk/Source/WTF/ChangeLog 2020-07-17 16:50:55 UTC (rev 264517)
+++ trunk/Source/WTF/ChangeLog 2020-07-17 17:26:45 UTC (rev 264518)
@@ -1,3 +1,16 @@
+2020-07-17 Keith Miller <[email protected]>
+
+ Fix 32-bit debug watchos build
+ https://bugs.webkit.org/show_bug.cgi?id=214480
+
+ Reviewed by Michael Saboff.
+
+ subtracting pointers produces a ptrdiff_t but on 32-bit that's the same
+ as an int. Since we were comparing that to an unsigned that triggered
+ the signed comparison warning, which broke the build.
+
+ * wtf/text/StringParsingBuffer.h:
+
2020-07-17 Truitt Savell <[email protected]>
Unreviewed, reverting r264482.
Modified: trunk/Source/WTF/wtf/text/StringParsingBuffer.h (264517 => 264518)
--- trunk/Source/WTF/wtf/text/StringParsingBuffer.h 2020-07-17 16:50:55 UTC (rev 264517)
+++ trunk/Source/WTF/wtf/text/StringParsingBuffer.h 2020-07-17 17:26:45 UTC (rev 264518)
@@ -52,7 +52,7 @@
{
ASSERT(characters <= end);
ASSERT(!characters == !end);
- ASSERT(end - characters <= std::numeric_limits<unsigned>::max());
+ ASSERT(static_cast<size_t>(end - characters) <= std::numeric_limits<unsigned>::max());
}
constexpr auto position() const { return m_position; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
