- Revision
- 264524
- Author
- [email protected]
- Date
- 2020-07-17 11:34:47 -0700 (Fri, 17 Jul 2020)
Log Message
REGRESSION(r264486): storage/indexeddb/structured-clone.html crashes
https://bugs.webkit.org/show_bug.cgi?id=214481
Patch by Sihui Liu <[email protected]> on 2020-07-17
Reviewed by Yusuke Suzuki.
r264486 added a new type RTCCertificate in structured-clone.html to test as many types in IDB as possible.
However, RTCCertificate is not supported before the fix because of a crash in web process. Given that this is a
separate issue, track it in https://bugs.webkit.org/show_bug.cgi?id=214447 and remove this type from test to
make sure it runs to the end on the bots.
* storage/indexeddb/resources/structured-clone.js:
(testRTCCertificate.promise.then): Deleted.
(testRTCCertificate): Deleted.
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone-private-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264523 => 264524)
--- trunk/LayoutTests/ChangeLog 2020-07-17 18:31:59 UTC (rev 264523)
+++ trunk/LayoutTests/ChangeLog 2020-07-17 18:34:47 UTC (rev 264524)
@@ -1,3 +1,21 @@
+2020-07-17 Sihui Liu <[email protected]>
+
+ REGRESSION(r264486): storage/indexeddb/structured-clone.html crashes
+ https://bugs.webkit.org/show_bug.cgi?id=214481
+
+ Reviewed by Yusuke Suzuki.
+
+ r264486 added a new type RTCCertificate in structured-clone.html to test as many types in IDB as possible.
+ However, RTCCertificate is not supported before the fix because of a crash in web process. Given that this is a
+ separate issue, track it in https://bugs.webkit.org/show_bug.cgi?id=214447 and remove this type from test to
+ make sure it runs to the end on the bots.
+
+ * storage/indexeddb/resources/structured-clone.js:
+ (testRTCCertificate.promise.then): Deleted.
+ (testRTCCertificate): Deleted.
+ * storage/indexeddb/structured-clone-expected.txt:
+ * storage/indexeddb/structured-clone-private-expected.txt:
+
2020-07-17 Carlos Alberto Lopez Perez <[email protected]>
Update WPT css directory
Modified: trunk/LayoutTests/storage/indexeddb/resources/structured-clone.js (264523 => 264524)
--- trunk/LayoutTests/storage/indexeddb/resources/structured-clone.js 2020-07-17 18:31:59 UTC (rev 264523)
+++ trunk/LayoutTests/storage/indexeddb/resources/structured-clone.js 2020-07-17 18:34:47 UTC (rev 264524)
@@ -52,7 +52,6 @@
testMap,
testSet,
testGeometryTypes,
- testRTCCertificate,
testCryptoKey
];
@@ -629,27 +628,6 @@
], callback);
}
-function testRTCCertificate(callback)
-{
- debug("Testing RTCCertificate");
- evalAndLog("promise = RTCPeerConnection.generateCertificate({ name: 'RSASSA-PKCS1-v1_5', modulusLength: 2048, publicExponent: new Uint8Array([1, 0, 1]), hash: 'SHA-256'})");
- promise.then((test_data) => {
- self.test_data = test_data;
- testValue(test_data, function(result) {
- self.result = result;
- shouldBeTrue("test_data !== result");
- shouldBeEqualToString("Object.prototype.toString.call(result)", "[object RTCCertificate]");
- shouldBe("test_data.expires", "result.expires");
- evalAndLog("dataFingerPrints = test_data.getFingerprints()");
- evalAndLog("resultFingerPrints = result.getFingerprints()");
- shouldBe("dataFingerPrints.length", "resultFingerPrints.length");
- shouldBe("test_data.getFingerprints()[0].algorithm", "resultFingerPrints[0].algorithm");
- shouldBe("test_data.getFingerprints()[0].value", "resultFingerPrints[0].value");
- callback();
- });
- });
-}
-
function testCryptoKey(callback)
{
debug("Testing CryptoKey");
Modified: trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt (264523 => 264524)
--- trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt 2020-07-17 18:31:59 UTC (rev 264523)
+++ trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt 2020-07-17 18:34:47 UTC (rev 264524)
@@ -886,21 +886,6 @@
PASS Object.prototype.toString.call(test_data) is Object.prototype.toString.call(result)
PASS test_data.toString() is result.toString()
-Testing RTCCertificate
-promise = RTCPeerConnection.generateCertificate({ name: 'RSASSA-PKCS1-v1_5', modulusLength: 2048, publicExponent: new Uint8Array([1, 0, 1]), hash: 'SHA-256'})
-transaction = db.transaction('storeName', 'readwrite')
-store = transaction.objectStore('storeName')
-store.put(value, 'key')
-store.get('key')
-PASS test_data !== result is true
-PASS Object.prototype.toString.call(result) is "[object RTCCertificate]"
-PASS test_data.expires is result.expires
-dataFingerPrints = test_data.getFingerprints()
-resultFingerPrints = result.getFingerprints()
-PASS dataFingerPrints.length is resultFingerPrints.length
-PASS test_data.getFingerprints()[0].algorithm is resultFingerPrints[0].algorithm
-PASS test_data.getFingerprints()[0].value is resultFingerPrints[0].value
-
Testing CryptoKey
promise = crypto.subtle.generateKey({ name: 'HMAC', hash: {name: 'SHA-512'}}, true, ['sign', 'verify']);
transaction = db.transaction('storeName', 'readwrite')
Modified: trunk/LayoutTests/storage/indexeddb/structured-clone-private-expected.txt (264523 => 264524)
--- trunk/LayoutTests/storage/indexeddb/structured-clone-private-expected.txt 2020-07-17 18:31:59 UTC (rev 264523)
+++ trunk/LayoutTests/storage/indexeddb/structured-clone-private-expected.txt 2020-07-17 18:34:47 UTC (rev 264524)
@@ -886,21 +886,6 @@
PASS Object.prototype.toString.call(test_data) is Object.prototype.toString.call(result)
PASS test_data.toString() is result.toString()
-Testing RTCCertificate
-promise = RTCPeerConnection.generateCertificate({ name: 'RSASSA-PKCS1-v1_5', modulusLength: 2048, publicExponent: new Uint8Array([1, 0, 1]), hash: 'SHA-256'})
-transaction = db.transaction('storeName', 'readwrite')
-store = transaction.objectStore('storeName')
-store.put(value, 'key')
-store.get('key')
-PASS test_data !== result is true
-PASS Object.prototype.toString.call(result) is "[object RTCCertificate]"
-PASS test_data.expires is result.expires
-dataFingerPrints = test_data.getFingerprints()
-resultFingerPrints = result.getFingerprints()
-PASS dataFingerPrints.length is resultFingerPrints.length
-PASS test_data.getFingerprints()[0].algorithm is resultFingerPrints[0].algorithm
-PASS test_data.getFingerprints()[0].value is resultFingerPrints[0].value
-
Testing CryptoKey
promise = crypto.subtle.generateKey({ name: 'HMAC', hash: {name: 'SHA-512'}}, true, ['sign', 'verify']);
transaction = db.transaction('storeName', 'readwrite')
