Title: [264533] trunk/Source
Revision
264533
Author
[email protected]
Date
2020-07-17 14:19:05 -0700 (Fri, 17 Jul 2020)

Log Message

Don't include <wtf/text/WTFString.h> in SVGParserUtilities.h
https://bugs.webkit.org/show_bug.cgi?id=214320

Reviewed by Darin Adler.

Source/WebCore:

r264332 mistakenly added #include <wtf/text/WTFString.h> in
ColorSerialization.h and SVGParserUtilities.h. It should be
<wtf/Forward.h>.

See <https://lists.webkit.org/pipermail/webkit-dev/2020-July/031274.html>
for the discussion.

* platform/graphics/ColorSerialization.h:
* svg/SVGParserUtilities.h:

Source/WTF:

* wtf/Forward.h: Added foward declarations for template specializations of DefaultHash.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (264532 => 264533)


--- trunk/Source/WTF/ChangeLog	2020-07-17 20:53:06 UTC (rev 264532)
+++ trunk/Source/WTF/ChangeLog	2020-07-17 21:19:05 UTC (rev 264533)
@@ -1,3 +1,12 @@
+2020-07-17  Fujii Hironori  <[email protected]>
+
+        Don't include <wtf/text/WTFString.h> in SVGParserUtilities.h
+        https://bugs.webkit.org/show_bug.cgi?id=214320
+
+        Reviewed by Darin Adler.
+
+        * wtf/Forward.h: Added foward declarations for template specializations of DefaultHash.
+
 2020-07-17  Keith Miller  <[email protected]>
 
         Fix 32-bit debug watchos build

Modified: trunk/Source/WTF/wtf/Forward.h (264532 => 264533)


--- trunk/Source/WTF/wtf/Forward.h	2020-07-17 20:53:06 UTC (rev 264532)
+++ trunk/Source/WTF/wtf/Forward.h	2020-07-17 21:19:05 UTC (rev 264533)
@@ -79,6 +79,13 @@
 template<typename, typename = EmptyCounter> class WeakPtr;
 
 template<typename> struct DefaultHash;
+template<> struct DefaultHash<AtomString>;
+template<typename T> struct DefaultHash<OptionSet<T>>;
+template<> struct DefaultHash<String>;
+template<> struct DefaultHash<StringImpl*>;
+template<> struct DefaultHash<URL>;
+template<typename T, size_t inlineCapacity> struct DefaultHash<Vector<T, inlineCapacity>>;
+
 template<typename> struct DumbValueTraits;
 template<typename> struct EnumTraits;
 template<typename E, E...> struct EnumValues;

Modified: trunk/Source/WebCore/ChangeLog (264532 => 264533)


--- trunk/Source/WebCore/ChangeLog	2020-07-17 20:53:06 UTC (rev 264532)
+++ trunk/Source/WebCore/ChangeLog	2020-07-17 21:19:05 UTC (rev 264533)
@@ -1,3 +1,20 @@
+2020-07-17  Fujii Hironori  <[email protected]>
+
+        Don't include <wtf/text/WTFString.h> in SVGParserUtilities.h
+        https://bugs.webkit.org/show_bug.cgi?id=214320
+
+        Reviewed by Darin Adler.
+
+        r264332 mistakenly added #include <wtf/text/WTFString.h> in
+        ColorSerialization.h and SVGParserUtilities.h. It should be
+        <wtf/Forward.h>.
+
+        See <https://lists.webkit.org/pipermail/webkit-dev/2020-July/031274.html>
+        for the discussion.
+
+        * platform/graphics/ColorSerialization.h:
+        * svg/SVGParserUtilities.h:
+
 2020-07-17  Wenson Hsieh  <[email protected]>
 
         Recommended article titles on csdn.net are clipped after translating to English

Modified: trunk/Source/WebCore/platform/graphics/ColorSerialization.h (264532 => 264533)


--- trunk/Source/WebCore/platform/graphics/ColorSerialization.h	2020-07-17 20:53:06 UTC (rev 264532)
+++ trunk/Source/WebCore/platform/graphics/ColorSerialization.h	2020-07-17 21:19:05 UTC (rev 264533)
@@ -25,7 +25,7 @@
 
 #pragma once
 
-#include <wtf/text/WTFString.h>
+#include <wtf/Forward.h>
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/svg/SVGParserUtilities.h (264532 => 264533)


--- trunk/Source/WebCore/svg/SVGParserUtilities.h	2020-07-17 20:53:06 UTC (rev 264532)
+++ trunk/Source/WebCore/svg/SVGParserUtilities.h	2020-07-17 21:19:05 UTC (rev 264533)
@@ -22,9 +22,7 @@
 #pragma once
 
 #include "ParsingUtilities.h"
-#include <wtf/HashSet.h>
-#include <wtf/Vector.h>
-#include <wtf/text/WTFString.h>
+#include <wtf/Forward.h>
 
 typedef std::pair<UChar32, UChar32> UnicodeRange;
 typedef Vector<UnicodeRange> UnicodeRanges;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to