Title: [264555] trunk
- Revision
- 264555
- Author
- [email protected]
- Date
- 2020-07-17 16:40:57 -0700 (Fri, 17 Jul 2020)
Log Message
[GTK] fast/events/context-activated-by-key-event.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=199444
Reviewed by Michael Catanzaro.
Source/WebKit:
GTK supports showing the context menu for keyboard events. In these
cases there may be no pending mouse events, causing the assert to
fail.
Covered by existing tests.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
LayoutTests:
* platform/gtk/TestExpectations: Remove fixed test entry.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264554 => 264555)
--- trunk/LayoutTests/ChangeLog 2020-07-17 23:35:51 UTC (rev 264554)
+++ trunk/LayoutTests/ChangeLog 2020-07-17 23:40:57 UTC (rev 264555)
@@ -1,3 +1,12 @@
+2020-07-17 Lauro Moura <[email protected]>
+
+ [GTK] fast/events/context-activated-by-key-event.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=199444
+
+ Reviewed by Michael Catanzaro.
+
+ * platform/gtk/TestExpectations: Remove fixed test entry.
+
2020-07-17 Truitt Savell <[email protected]>
Rebase compositing/repaint/iframes/compositing-iframe-scroll-repaint.html back to previous state after r264522
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (264554 => 264555)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-07-17 23:35:51 UTC (rev 264554)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-07-17 23:40:57 UTC (rev 264555)
@@ -40,9 +40,6 @@
# Accessibility
webkit.org/b/214341 [ Debug ] accessibility/datalist.html [ Crash ]
-# Events
-webkit.org/b/199444 [ Debug ] fast/events/context-activated-by-key-event.html [ Crash ]
-
# GStreamer - GTK-Only. Most GStreamer issues probably will go in the glib expectations
webkit.org/b/210528 media/video-supports-fullscreen.html [ Crash Pass ]
Modified: trunk/Source/WebKit/ChangeLog (264554 => 264555)
--- trunk/Source/WebKit/ChangeLog 2020-07-17 23:35:51 UTC (rev 264554)
+++ trunk/Source/WebKit/ChangeLog 2020-07-17 23:40:57 UTC (rev 264555)
@@ -1,3 +1,19 @@
+2020-07-17 Lauro Moura <[email protected]>
+
+ [GTK] fast/events/context-activated-by-key-event.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=199444
+
+ Reviewed by Michael Catanzaro.
+
+ GTK supports showing the context menu for keyboard events. In these
+ cases there may be no pending mouse events, causing the assert to
+ fail.
+
+ Covered by existing tests.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::showContextMenu):
+
2020-07-17 Per Arne Vollan <[email protected]>
Add Launch Services database update logging
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (264554 => 264555)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-07-17 23:35:51 UTC (rev 264554)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-07-17 23:40:57 UTC (rev 264555)
@@ -6547,7 +6547,6 @@
// Discard any enqueued mouse events that have been delivered to the UIProcess whilst the WebProcess is still processing the
// MouseDown event that triggered this ShowContextMenu message. This can happen if we take too long to enter the nested runloop.
- ASSERT(isProcessingMouseEvents());
discardQueuedMouseEvents();
m_activeContextMenuContextData = contextMenuContextData;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
