Title: [264568] trunk/Source/WebCore
- Revision
- 264568
- Author
- [email protected]
- Date
- 2020-07-18 09:23:48 -0700 (Sat, 18 Jul 2020)
Log Message
Unreviewed, fix build warnings in the WebXR backend
* platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::Instance::Impl::enumerateInstanceExtensionProperties const): Guard log loop
with LOG_DISABLED macro, to avoid unused variable warnings in release builds.
* testing/WebFakeXRDevice.h: Remove unused private class member.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264567 => 264568)
--- trunk/Source/WebCore/ChangeLog 2020-07-18 12:24:59 UTC (rev 264567)
+++ trunk/Source/WebCore/ChangeLog 2020-07-18 16:23:48 UTC (rev 264568)
@@ -1,3 +1,12 @@
+2020-07-18 Philippe Normand <[email protected]>
+
+ Unreviewed, fix build warnings in the WebXR backend
+
+ * platform/xr/openxr/PlatformXROpenXR.cpp:
+ (PlatformXR::Instance::Impl::enumerateInstanceExtensionProperties const): Guard log loop
+ with LOG_DISABLED macro, to avoid unused variable warnings in release builds.
+ * testing/WebFakeXRDevice.h: Remove unused private class member.
+
2020-07-18 Commit Queue <[email protected]>
Unreviewed, reverting r264563.
Modified: trunk/Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp (264567 => 264568)
--- trunk/Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp 2020-07-18 12:24:59 UTC (rev 264567)
+++ trunk/Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp 2020-07-18 16:23:48 UTC (rev 264568)
@@ -128,11 +128,13 @@
uint32_t propertyCountWritten { 0 };
result = xrEnumerateInstanceExtensionProperties(nullptr, propertyCountOutput, &propertyCountWritten, properties.data());
RETURN_IF_FAILED(result, "xrEnumerateInstanceExtensionProperties()", m_instance);
+#if !LOG_DISABLED
LOG(XR, "xrEnumerateInstanceExtensionProperties(): %zu extension properties\n", properties.size());
for (auto& property : properties) {
LOG(XR, " extension '%s', version %u\n",
property.extensionName, property.extensionVersion);
}
+#endif
}
#endif // USE_OPENXR
Modified: trunk/Source/WebCore/testing/WebFakeXRDevice.h (264567 => 264568)
--- trunk/Source/WebCore/testing/WebFakeXRDevice.h 2020-07-18 12:24:59 UTC (rev 264567)
+++ trunk/Source/WebCore/testing/WebFakeXRDevice.h 2020-07-18 16:23:48 UTC (rev 264568)
@@ -74,7 +74,6 @@
RefPtr<WebXRRigidTransform> m_viewerOrigin;
RefPtr<WebXRRigidTransform> m_floorOrigin;
bool m_emulatedPosition { false };
- XRVisibilityState m_visibilityState { XRVisibilityState::Visible };
Vector<Ref<FakeXRView>> m_views;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
