Title: [264576] trunk/Source/_javascript_Core
- Revision
- 264576
- Author
- [email protected]
- Date
- 2020-07-19 06:59:36 -0700 (Sun, 19 Jul 2020)
Log Message
cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="?
https://bugs.webkit.org/show_bug.cgi?id=214530
Patch by Michael Catanzaro <[email protected]> on 2020-07-19
Reviewed by Philippe Normand.
* inspector/scripts/codegen/cpp_generator.py:
(CppGenerator.cpp_type_for_unchecked_formal_in_parameter):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (264575 => 264576)
--- trunk/Source/_javascript_Core/ChangeLog 2020-07-19 04:24:20 UTC (rev 264575)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-07-19 13:59:36 UTC (rev 264576)
@@ -1,3 +1,13 @@
+2020-07-19 Michael Catanzaro <[email protected]>
+
+ cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="?
+ https://bugs.webkit.org/show_bug.cgi?id=214530
+
+ Reviewed by Philippe Normand.
+
+ * inspector/scripts/codegen/cpp_generator.py:
+ (CppGenerator.cpp_type_for_unchecked_formal_in_parameter):
+
2020-07-18 Mark Lam <[email protected]>
Fixed regression due to r264507: Math.{min|max} inequality test should use DoubleNotEqualOrUnordered instead DoubleNotEqualAndOrdered.
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py (264575 => 264576)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py 2020-07-19 04:24:20 UTC (rev 264575)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator.py 2020-07-19 13:59:36 UTC (rev 264576)
@@ -131,7 +131,7 @@
_type = _type.primitive_type # Fall through to primitive.
# This handles the 'any' type and objects with defined properties.
- if isinstance(_type, ObjectType) or _type.qualified_name() is 'object':
+ if isinstance(_type, ObjectType) or _type.qualified_name() == 'object':
cpp_name = 'JSON::Object'
if parameter.is_optional:
return 'const %s*' % cpp_name
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
