Title: [264581] trunk/Tools
Revision
264581
Author
[email protected]
Date
2020-07-19 12:06:23 -0700 (Sun, 19 Jul 2020)

Log Message

cpp.py:3688: FutureWarning: Possible nested set at position 101
https://bugs.webkit.org/show_bug.cgi?id=214536

Patch by Michael Catanzaro <[email protected]> on 2020-07-19
Reviewed by Darin Adler.

The warning was added in https://bugs.python.org/issue30349. We need to escape [ when used
inside a set. That is, we have to change "[[" to "[\[".

* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (264580 => 264581)


--- trunk/Tools/ChangeLog	2020-07-19 19:05:53 UTC (rev 264580)
+++ trunk/Tools/ChangeLog	2020-07-19 19:06:23 UTC (rev 264581)
@@ -1,5 +1,18 @@
 2020-07-19  Michael Catanzaro  <[email protected]>
 
+        cpp.py:3688: FutureWarning: Possible nested set at position 101
+        https://bugs.webkit.org/show_bug.cgi?id=214536
+
+        Reviewed by Darin Adler.
+
+        The warning was added in https://bugs.python.org/issue30349. We need to escape [ when used
+        inside a set. That is, we have to change "[[" to "[\[".
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_identifier_name_in_declaration):
+
+2020-07-19  Michael Catanzaro  <[email protected]>
+
         Fix -Wdeprecated-declarations under Tools
         https://bugs.webkit.org/show_bug.cgi?id=214534
 

Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (264580 => 264581)


--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2020-07-19 19:05:53 UTC (rev 264580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2020-07-19 19:06:23 UTC (rev 264581)
@@ -3777,7 +3777,7 @@
     type_regexp = r'\w([\w]|\s*[*&]\s*|::)+'
     identifier_regexp = r'(?P<identifier>[\w:]+)'
     maybe_bitfield_regexp = r'(:\s*\d+\s*)?'
-    character_after_identifier_regexp = r'(?P<character_after_identifier>[[;()=,])(?!=)'
+    character_after_identifier_regexp = r'(?P<character_after_identifier>[\[;()=,])(?!=)'
     declaration_without_type_regexp = r'\s*' + identifier_regexp + r'\s*' + maybe_bitfield_regexp + character_after_identifier_regexp
     declaration_with_type_regexp = r'\s*' + type_regexp + r'\s' + declaration_without_type_regexp
     constructor_regexp = r'\s*([\w_]*::)*(?P<pre_part>[\w_]+)::(?P<post_part>[\w_]+)[(]'
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to