Title: [264589] trunk/Source/WebCore
- Revision
- 264589
- Author
- [email protected]
- Date
- 2020-07-19 19:04:40 -0700 (Sun, 19 Jul 2020)
Log Message
Unreviewed, reverting r264588.
It broke Mac port.
Reverted changeset:
"Use forward template declarations for ColorComponents instead
of including ColorComponents.h as much as possible"
https://bugs.webkit.org/show_bug.cgi?id=214204
https://trac.webkit.org/changeset/264588
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264588 => 264589)
--- trunk/Source/WebCore/ChangeLog 2020-07-20 01:51:33 UTC (rev 264588)
+++ trunk/Source/WebCore/ChangeLog 2020-07-20 02:04:40 UTC (rev 264589)
@@ -1,5 +1,18 @@
2020-07-19 Fujii Hironori <[email protected]>
+ Unreviewed, reverting r264588.
+
+ It broke Mac port.
+
+ Reverted changeset:
+
+ "Use forward template declarations for ColorComponents instead
+ of including ColorComponents.h as much as possible"
+ https://bugs.webkit.org/show_bug.cgi?id=214204
+ https://trac.webkit.org/changeset/264588
+
+2020-07-19 Fujii Hironori <[email protected]>
+
Use forward template declarations for ColorComponents instead of including ColorComponents.h as much as possible
https://bugs.webkit.org/show_bug.cgi?id=214204
<rdar://problem/65414170>
Modified: trunk/Source/WebCore/platform/graphics/ColorConversion.cpp (264588 => 264589)
--- trunk/Source/WebCore/platform/graphics/ColorConversion.cpp 2020-07-20 01:51:33 UTC (rev 264588)
+++ trunk/Source/WebCore/platform/graphics/ColorConversion.cpp 2020-07-20 02:04:40 UTC (rev 264589)
@@ -28,6 +28,7 @@
#include "ColorComponents.h"
#include "ColorMatrix.h"
+#include "ColorTypes.h"
namespace WebCore {
Modified: trunk/Source/WebCore/platform/graphics/ColorMatrix.h (264588 => 264589)
--- trunk/Source/WebCore/platform/graphics/ColorMatrix.h 2020-07-20 01:51:33 UTC (rev 264588)
+++ trunk/Source/WebCore/platform/graphics/ColorMatrix.h 2020-07-20 02:04:40 UTC (rev 264589)
@@ -25,13 +25,12 @@
#pragma once
+#include "ColorComponents.h"
#include <math.h>
#include <wtf/MathExtras.h>
namespace WebCore {
-template<typename> struct ColorComponents;
-
template<size_t Columns, size_t Rows>
class ColorMatrix {
public:
Modified: trunk/Source/WebCore/platform/graphics/ColorTypes.h (264588 => 264589)
--- trunk/Source/WebCore/platform/graphics/ColorTypes.h 2020-07-20 01:51:33 UTC (rev 264588)
+++ trunk/Source/WebCore/platform/graphics/ColorTypes.h 2020-07-20 02:04:40 UTC (rev 264589)
@@ -25,11 +25,11 @@
#pragma once
+#include "ColorComponents.h"
#include "ColorSpace.h"
namespace WebCore {
-template<typename> struct ColorComponents;
template<typename> struct ComponentTraits;
template<> struct ComponentTraits<uint8_t> {
Modified: trunk/Source/WebCore/platform/graphics/ColorUtilities.h (264588 => 264589)
--- trunk/Source/WebCore/platform/graphics/ColorUtilities.h 2020-07-20 01:51:33 UTC (rev 264588)
+++ trunk/Source/WebCore/platform/graphics/ColorUtilities.h 2020-07-20 02:04:40 UTC (rev 264589)
@@ -25,6 +25,7 @@
#pragma once
+#include "ColorTypes.h"
#include <algorithm>
#include <cmath>
#include <math.h>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
