Title: [264592] trunk/Source/WebKit
Revision
264592
Author
[email protected]
Date
2020-07-20 01:24:51 -0700 (Mon, 20 Jul 2020)

Log Message

valgrind claims uninitialized memory when opening inspector (WebKit::InspectorBrowserAgent::enable(WTF::String&))
https://bugs.webkit.org/show_bug.cgi?id=209468

Reviewed by Michael Catanzaro.

Initialize m_targetAgent.

* UIProcess/Inspector/WebPageInspectorController.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (264591 => 264592)


--- trunk/Source/WebKit/ChangeLog	2020-07-20 03:31:17 UTC (rev 264591)
+++ trunk/Source/WebKit/ChangeLog	2020-07-20 08:24:51 UTC (rev 264592)
@@ -1,3 +1,14 @@
+2020-07-20  Carlos Garcia Campos  <[email protected]>
+
+        valgrind claims uninitialized memory when opening inspector (WebKit::InspectorBrowserAgent::enable(WTF::String&))
+        https://bugs.webkit.org/show_bug.cgi?id=209468
+
+        Reviewed by Michael Catanzaro.
+
+        Initialize m_targetAgent.
+
+        * UIProcess/Inspector/WebPageInspectorController.h:
+
 2020-07-19  Sam Weinig  <[email protected]>
 
         Rename Color::transparent to Color::transparentBlack to more clearly state what it is

Modified: trunk/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h (264591 => 264592)


--- trunk/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h	2020-07-20 03:31:17 UTC (rev 264591)
+++ trunk/Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h	2020-07-20 08:24:51 UTC (rev 264592)
@@ -91,7 +91,7 @@
 
     WebPageProxy& m_page;
 
-    Inspector::InspectorTargetAgent* m_targetAgent;
+    Inspector::InspectorTargetAgent* m_targetAgent { nullptr };
     HashMap<String, std::unique_ptr<InspectorTargetProxy>> m_targets;
 
     InspectorBrowserAgent* m_enabledBrowserAgent;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to